From 605f889ab57c3465523104812fbf3edeb1e513d9 Mon Sep 17 00:00:00 2001 From: June McEnroe Date: Sun, 16 Jan 2022 14:17:46 -0500 Subject: Avoid sending null byte in SASL PLAIN Woops! BASE64_SIZE is the size of the string buffer. Somehow ergo is the only server software (that I know of) to reject the accidental null byte. Reported by smlavine. --- handle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handle.c b/handle.c index 5d61081..e460c7c 100644 --- a/handle.c +++ b/handle.c @@ -219,7 +219,7 @@ static void handleAuthenticate(struct Message *msg) { char b64[BASE64_SIZE(sizeof(buf))]; base64(b64, buf, len); ircFormat("AUTHENTICATE "); - ircSend(b64, BASE64_SIZE(len)); + ircSend(b64, BASE64_SIZE(len) - 1); ircFormat("\r\n"); explicit_bzero(b64, sizeof(b64)); -- cgit 1.4.1 s='sub right'>
about summary refs log tree commit diff
BranchCommit messageAuthorAge
wikiUpdate nixpkgs link to new locationWinston R. Milling13 months
mastergit: update to v2.37.1Christian Hesse2 years
 
TagDownloadAuthorAge
1.4.1cgit-pink-1.4.1.tar.gz  cgit-pink-1.4.1.zip  June McEnroe3 years
1.4.0cgit-pink-1.4.0.tar.gz  cgit-pink-1.4.0.zip  June McEnroe3 years
1.3.0cgit-pink-1.3.0.tar.gz  cgit-pink-1.3.0.zip  June McEnroe3 years
 
AgeCommit messageAuthor
2022-07-27git: update to v2.37.1 HEAD masterChristian Hesse
2022-07-01git: update to v2.37.0Christian Hesse
2022-05-17Bump version to 1.4.1 1.4.1June McEnroe
2022-05-17Fix bad free in cgit_diff_treeJune McEnroe
2022-05-15Bump version to 1.4.0 1.4.0June McEnroe
2022-05-13Tolerate short writes in print_slot