From b4ca3a5dfc459505c5abb40f73927fe91d38e640 Mon Sep 17 00:00:00 2001 From: Curtis McEnroe Date: Mon, 20 Aug 2018 19:11:44 -0400 Subject: Don't clobber tab order on /who --- chat.h | 1 + handle.c | 3 +-- tab.c | 31 ++++++++++++++++++++++++------- 3 files changed, 26 insertions(+), 9 deletions(-) diff --git a/chat.h b/chat.h index 4ec5dcd..781d25a 100644 --- a/chat.h +++ b/chat.h @@ -142,6 +142,7 @@ const wchar_t *editHead(void); const wchar_t *editTail(void); void tabTouch(struct Tag tag, const char *word); +void tabAdd(struct Tag tag, const char *word); void tabRemove(struct Tag tag, const char *word); void tabReplace(struct Tag tag, const char *prev, const char *next); void tabClear(struct Tag tag); diff --git a/handle.c b/handle.c index 0036100..07c5a62 100644 --- a/handle.c +++ b/handle.c @@ -308,8 +308,7 @@ static void handleReplyWho(char *prefix, char *params) { ); struct Tag tag = tagFor(chan); - // FIXME: Don't clobber order if they already exist. - tabTouch(tag, nick); + tabAdd(tag, nick); size_t cap = sizeof(who.buf) - who.len; int len = snprintf( diff --git a/tab.c b/tab.c index 87e4f02..a242365 100644 --- a/tab.c +++ b/tab.c @@ -47,14 +47,16 @@ static void touch(struct Entry *entry) { prepend(entry); } -void tabTouch(struct Tag tag, const char *word) { +static struct Entry *find(struct Tag tag, const char *word) { for (struct Entry *entry = head; entry; entry = entry->next) { if (entry->tag.id != tag.id) continue; if (strcmp(entry->word, word)) continue; - touch(entry); - return; + return entry; } + return NULL; +} +static void add(struct Tag tag, const char *word) { struct Entry *entry = malloc(sizeof(*entry)); if (!entry) err(EX_OSERR, "malloc"); @@ -65,11 +67,26 @@ void tabTouch(struct Tag tag, const char *word) { prepend(entry); } +void tabTouch(struct Tag tag, const char *word) { + struct Entry *entry = find(tag, word); + if (entry) { + touch(entry); + } else { + add(tag, word); + } +} + +void tabAdd(struct Tag tag, const char *word) { + if (!find(tag, word)) add(tag, word); +} + void tabReplace(struct Tag tag, const char *prev, const char *next) { - tabTouch(tag, prev); - free(head->word); - head->word = strdup(next); - if (!head->word) err(EX_OSERR, "strdup"); + struct Entry *entry = find(tag, prev); + if (!entry) return; + touch(entry); + free(entry->word); + entry->word = strdup(next); + if (!entry->word) err(EX_OSERR, "strdup"); } static struct Entry *iter; -- cgit 1.4.1 rot13.sh (unfollow)
Commit message (Collapse)Author
2019-05-15Implement sizeof in orderJune McEnroe
2019-05-15Add orderJune McEnroe
2019-05-12Add T suffix in bitJune McEnroe
2019-05-10Highlight yacc and lex files as CJune McEnroe
Their %-prefixed directives should probably be highlighted Macro.
2019-05-10Use val instead of suboptargJune McEnroe
suboptarg doesn't exist in GNU. Hopefully BSD getsubopt also sets val on failure?
2019-05-09Add Parable of the SowerJune McEnroe
2019-05-07Add bit without buildJune McEnroe
Need to do some stuff in the Makefile for lex and yacc and generating HTML pages for it.
2019-05-04Fix MANDIR typoJune McEnroe
2019-05-04Move relay to binJune McEnroe