From 9927e63f387e6c9328eb3c347ecb0e339f8ac023 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 14 May 2007 23:58:29 +0200 Subject: Specify static storage class for file-local declarations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also fix some whitespace issues while at it. Noticed by Kristian Høgsberg Signed-off-by: Lars Hjemli --- ui-commit.c | 8 ++++---- ui-summary.c | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ui-commit.c b/ui-commit.c index 20a7cb2..b6a106f 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -8,11 +8,11 @@ #include "cgit.h" -int files = 0, slots = 0; -int total_adds = 0, total_rems = 0, max_changes = 0; -int lines_added, lines_removed; +static int files, slots; +static int total_adds, total_rems, max_changes; +static int lines_added, lines_removed; -struct fileinfo { +static struct fileinfo { char status; unsigned char old_sha1[20]; unsigned char new_sha1[20]; diff --git a/ui-summary.c b/ui-summary.c index 9388f5f..f6120f9 100644 --- a/ui-summary.c +++ b/ui-summary.c @@ -8,7 +8,7 @@ #include "cgit.h" -int items = 0; +static int items; static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, int flags, void *cb_data) @@ -22,7 +22,7 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, if (commit && !parse_commit(commit)){ info = cgit_parse_commit(commit); html(""); - url = cgit_pageurl(cgit_query_repo, "log", + url = cgit_pageurl(cgit_query_repo, "log", fmt("h=%s", refname)); html_link_open(url, NULL, NULL); html_txt(buf); @@ -32,7 +32,7 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, html(""); html_txt(info->author); html(""); - url = cgit_pageurl(cgit_query_repo, "commit", + url = cgit_pageurl(cgit_query_repo, "commit", fmt("id=%s", sha1_to_hex(sha1))); html_link_open(url, NULL, NULL); html_ntxt(cgit_max_msg_len, info->subject); @@ -61,10 +61,10 @@ static void cgit_print_object_ref(struct object *obj) else page = "view"; - url = cgit_pageurl(cgit_query_repo, page, + url = cgit_pageurl(cgit_query_repo, page, fmt("id=%s", sha1_to_hex(obj->sha1))); html_link_open(url, NULL, NULL); - htmlf("%s %s", typename(obj->type), + htmlf("%s %s", typename(obj->type), sha1_to_hex(obj->sha1)); html_link_close(); } @@ -76,7 +76,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1, struct taginfo *info; struct object *obj; char buf[256], *url; - + strncpy(buf, refname, sizeof(buf)); obj = parse_object(sha1); if (!obj) @@ -93,7 +93,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1, } items++; html(""); - url = cgit_pageurl(cgit_query_repo, "view", + url = cgit_pageurl(cgit_query_repo, "view", fmt("id=%s", sha1_to_hex(sha1))); html_link_open(url, NULL, NULL); html_txt(buf); -- cgit 1.4.1 .c?h=1.1&id=2571d6ef5533b005f0f3ece462736693f354f986&follow=1'>Mark sig_atomic_t array volatileJune McEnroe 2019-07-02Add /listJune McEnroe 2019-07-02Deal with ~users in colorGenJune McEnroe 2019-07-02Clean up input parameter handlingJune McEnroe 2019-07-02Split /raw and /quoteJune McEnroe 2019-07-02Add -k option for joining with keysJune McEnroe 2019-07-02Add optional key to /joinJune McEnroe 2019-07-02Restart process in sandmanJune McEnroe 2019-02-27Add /move commandJune McEnroe 2019-02-26Add M-/ to switch to previously active windowJune McEnroe 2019-02-25Move nick and tag coloring to color.cJune McEnroe 2019-02-25Add M-l to list the logJune McEnroe 2019-02-25Output raw to standard error if it is not a terminalJune McEnroe 2019-02-25Update tag colorsJune McEnroe 2019-02-25Add color to tagsJune McEnroe 2019-02-25Remove tag X macros againJune McEnroe 2019-02-25Add M-a to switch to hot or unread windowJune McEnroe 2019-02-25Refactor uiReadJune McEnroe 2019-02-24Scroll by full pages with PageUp/PageDownJune McEnroe 2019-02-23Clarify /window documentationJune McEnroe 2019-02-23Use first word of params in input commandsJune McEnroe 2019-02-23Add C-n and C-p key bindings to switch windowsJune McEnroe 2019-02-23Change example command to join #ascii.town on freenodeJune McEnroe 2019-02-23Call def_prog_mode after termNoFlowJune McEnroe 2019-02-22Move IRC formatting reset to C-sJune McEnroe 2019-02-22Disable terminal flow controlJune McEnroe 2019-02-22Bind up and down arrows to scrollJune McEnroe 2019-02-22Remove topic TODOJune McEnroe 2019-02-22Add /znc commandJune McEnroe 2019-02-22Update status line after scrolling and term eventsJune McEnroe 2019-02-22Reorganize input.cJune McEnroe 2019-02-22Fix name of <raw> window in man pageJune McEnroe 2019-02-22Rename global tags with angle bracketsJune McEnroe 2019-02-22Show status window while connectingJune McEnroe 2019-02-22Reorganize UI code for the umpteenth timeJune McEnroe 2019-02-21Replace "view" with "window"June McEnroe 2019-02-21Remove ROT13June McEnroe 2019-02-21Clean up man pageJune McEnroe 2019-01-26Draw UI before connectingJune McEnroe 2019-01-25Avoid unused variable warnings with getyxJune McEnroe 2019-01-25Add GNU/Linux build instructionsJune McEnroe