From f5069d88dff7a7ed2f4665904b03e906cca75a7c Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 11 Dec 2006 09:57:58 +0100 Subject: Fix cache algorithm loophole This closes the door for unneccessary calls to cgit_fill_cache(). Noticed by Linus. Signed-off-by: Lars Hjemli --- cache.c | 6 +++++- cgit.c | 18 +++++++++--------- cgit.h | 3 ++- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/cache.c b/cache.c index b034c48..0ffa502 100644 --- a/cache.c +++ b/cache.c @@ -10,7 +10,7 @@ const int NOLOCK = -1; -int cache_lookup(struct cacheitem *item) +void cache_prepare(struct cacheitem *item) { if (!cgit_query_repo) { item->name = xstrdup(fmt("%s/index.html", cgit_cache_root)); @@ -30,6 +30,10 @@ int cache_lookup(struct cacheitem *item) else item->ttl = cgit_cache_repo_ttl; } +} + +int cache_exist(struct cacheitem *item) +{ if (stat(item->name, &item->st)) { item->st.st_mtime = 0; return 0; diff --git a/cgit.c b/cgit.c index 110face..7f14016 100644 --- a/cgit.c +++ b/cgit.c @@ -465,20 +465,20 @@ static void cgit_fill_cache(struct cacheitem *item) static void cgit_refresh_cache(struct cacheitem *item) { + cache_prepare(item); top: - if (!cache_lookup(item)) { - if (cache_lock(item)) { - cgit_fill_cache(item); - cache_unlock(item); - } else { + if (!cache_exist(item)) { + if (!cache_lock(item)) { sched_yield(); goto top; } - } else if (cache_expired(item)) { - if (cache_lock(item)) { + if (!cache_exist(item)) cgit_fill_cache(item); - cache_unlock(item); - } + cache_unlock(item); + } else if (cache_expired(item) && cache_lock(item)) { + if (cache_expired(item)) + cgit_fill_cache(item); + cache_unlock(item); } } diff --git a/cgit.h b/cgit.h index 1e084d4..3b0994a 100644 --- a/cgit.h +++ b/cgit.h @@ -56,9 +56,10 @@ extern void html_link_close(void); extern int cgit_read_config(const char *filename, configfn fn); -extern int cache_lookup(struct cacheitem *item); +extern void cache_prepare(struct cacheitem *item); extern int cache_lock(struct cacheitem *item); extern int cache_unlock(struct cacheitem *item); +extern int cache_exist(struct cacheitem *item); extern int cache_expired(struct cacheitem *item); #endif /* CGIT_H */ -- cgit 1.4.1 fb3655df3bf85bd405c5921bbd4b3a54c705c839&follow=1'>root/tests/t0105-commit.sh (unfollow)
Commit message (Expand)Author
2013-04-08Remove redundant calls to fmt("%s", ...)John Keeping
2013-04-08Convert cgit_print_error to a variadic functionJohn Keeping
2013-04-08shared.c: add strbuf_ensure_endJohn Keeping
2013-04-08html.c: add various strbuf and varadic helpersJohn Keeping
2013-04-08Mark char* fields in struct cgit_page as constJohn Keeping
2013-04-08Fix out-of-bounds memory accesses with virtual_root=""John Keeping
2013-04-08ui-refs.c: Refactor print_tag()Lukas Fleischer
2013-04-08ui-refs.c: Remove global header variableLukas Fleischer
2013-04-08html.c: Replace strdup() with xstrdup()Lukas Fleischer
2013-04-08Always #include corresponding .h in .c filesJohn Keeping
2013-04-08cgit.mk: fix dependency handlingJohn Keeping
2013-04-08Makefile: re-include cgit.conf in cgit.mkJohn Keeping
2013-04-08Do not unnecessarily strdup() environment variablesLukas Fleischer
2013-04-08Maŕk cgit_environment members constLukas Fleischer
2013-04-08Return const char * in cgit_{httpscheme, hosturl, rooturl}()Lukas Fleischer
2013-04-08Update git to v1.8.2.1John Keeping
2013-04-07ui-blob: don't segfault when no path is givenJohn Keeping
2013-03-20Convert pager navigation into a unordered listLukas Fleischer
2013-03-20Makefile: remove CGIT-CFLAGS files in clean stageJason A. Donenfeld
2013-03-20ui-summary.c: Move urls variable into print_urls()Lukas Fleischer
2013-03-20Fix colspan valuesLukas Fleischer
2013-03-20html: check return value of writeJason A. Donenfeld
2013-03-20ui-shared: squelch compiler warning.Jason A. Donenfeld
2013-03-20cgit.mk: Use SHELL_PATH_SQ to run gen-version.shJohn Keeping
2013-03-20cgit.mk: don't rebuild everything if CGIT_VERSION changesJohn Keeping
2013-03-20ui-patch: use cgit_version not CGIT_VERSIONJohn Keeping
2013-03-20Makefile: re-use Git's Makefile where possibleJohn Keeping