From af2e75616d1bfb7dc79d299d10ae0bd39bef47bc Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Sun, 18 May 2008 23:59:11 +0200 Subject: cache.c: do not ignore errors from print_slot() If print_slot() fails, the client will be served an inferior response. This patch makes sure that such an error will be returned to main(), which in turn will try to inform about the error in the response itself. The error is also printed to the cache_log, i.e. stderr, which will make the error message appear in error_log (atleast when httpd==apache). Noticed-by: Jim Meyering Signed-off-by: Lars Hjemli --- cache.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'cache.c') diff --git a/cache.c b/cache.c index a996109..aa97ae1 100644 --- a/cache.c +++ b/cache.c @@ -252,9 +252,14 @@ static int process_slot(struct cache_slot *slot) } } } - print_slot(slot); + if ((err = print_slot(slot)) != 0) { + cache_log("[cgit] error printing cache %s: %s (%d)\n", + slot->cache_name, + strerror(err), + err); + } close_slot(slot); - return 0; + return err; } /* If the cache slot does not exist (or its key doesn't match the @@ -289,7 +294,12 @@ static int process_slot(struct cache_slot *slot) // the lock file. slot->cache_fd = slot->lock_fd; unlock_slot(slot, 1); - err = print_slot(slot); + if ((err = print_slot(slot)) != 0) { + cache_log("[cgit] error printing cache %s: %s (%d)\n", + slot->cache_name, + strerror(err), + err); + } close_slot(slot); return err; } -- cgit 1.4.1