From af2e75616d1bfb7dc79d299d10ae0bd39bef47bc Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Sun, 18 May 2008 23:59:11 +0200 Subject: cache.c: do not ignore errors from print_slot() If print_slot() fails, the client will be served an inferior response. This patch makes sure that such an error will be returned to main(), which in turn will try to inform about the error in the response itself. The error is also printed to the cache_log, i.e. stderr, which will make the error message appear in error_log (atleast when httpd==apache). Noticed-by: Jim Meyering Signed-off-by: Lars Hjemli --- cgit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cgit.c') diff --git a/cgit.c b/cgit.c index 2036ceb..ac882c3 100644 --- a/cgit.c +++ b/cgit.c @@ -380,7 +380,7 @@ int main(int argc, const char **argv) err = cache_process(ctx.cfg.cache_size, ctx.cfg.cache_root, ctx.qry.raw, ttl, process_request, &ctx); if (err) - cache_log("[cgit] error %d - %s\n", - err, strerror(err)); + cgit_print_error(fmt("Error processing page: %s (%d)", + strerror(err), err)); return err; } -- cgit 1.4.1 rse.c?h=1.1&id=6391b773b79afda4b5baa4d336bd350e02ba4044'>tree commit diff
path: root/parse.c (unfollow)
Commit message (Expand)Author
2020-04-30Remove +1sJune McEnroe
2020-04-30Rename baseAddress to baseMailtoJune McEnroe
2020-04-30Swap -s and -SJune McEnroe
2020-04-30Add -S for subscribe linkJune McEnroe
2020-04-30Add install, uninstall targetsJune McEnroe
2020-04-30Wrap footer text in <small>June McEnroe
2020-04-30Nest <q> elements for increased levels of quotationJune McEnroe
2020-04-29Use a table to decode base64June McEnroe
2020-04-29Fix infinite loop if exportAtom can't find a text partJune McEnroe
2020-04-29Highlight diff/index/---/+++ lines of patches as wellJune McEnroe
2020-04-29Turn URLs into HTML linksJune McEnroe
2020-04-28Clean up html.cJune McEnroe
2020-04-27Style groups in recipientsJune McEnroe
2020-04-27Clean up export.cJune McEnroe
2020-04-27Clean up decode.cJune McEnroe
2020-04-26Free orderJune McEnroe
2020-04-26Clean up atom.c and fix base URLsJune McEnroe
2020-04-26Clean up archive.cJune McEnroe
2020-04-26Add -q to exit non-zero on early exitJune McEnroe
2020-04-26Rearrange some of archive.hJune McEnroe
2020-04-26Free part.parts.ptrJune McEnroe
2020-04-26Rename part->id to part->contentIDJune McEnroe
2020-04-26Iterate through nested multiparts to find content for AtomJune McEnroe
2020-04-26Include Cc address in reply mailtosJune McEnroe
2020-04-26Use %R for RFC numbers in STANDARDS sectionJune McEnroe
2020-04-26Add mailto spec to STANDARDSJune McEnroe
2020-04-26Increase space between nav itemsJune McEnroe
2020-04-26Add mailto address for the archiveJune McEnroe
2020-04-26Put dates on new lines in indexJune McEnroe
2020-04-26Include <> around Message-Id in mailto: URLsJune McEnroe
2020-04-26Add link to index on thread pagesJune McEnroe
2020-04-26Fall back to Content-Type name parameter for attachmentsJune McEnroe
2020-04-26Remove margins in article.message headerJune McEnroe
2020-04-26Generate index.atomJune McEnroe
2020-04-26Generate XHTML content in Atom entriesJune McEnroe
2020-04-25Style index pageJune McEnroe
2020-04-25Render index.htmlJune McEnroe
2020-04-25Wrap <summary> replies count in <data>June McEnroe
2020-04-25Accumulate thread envelopes before concatenationJune McEnroe
2020-04-24Free envelope in concatDataJune McEnroe
2020-04-24Use replyTo address in mailto:June McEnroe
2020-04-23Wrap quoted lines in <q>June McEnroe