From 60a26272e0ca529407fe6b613f061f04ba585d53 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 10 Aug 2009 08:21:09 +0200 Subject: Cleanup handling of environment variables Signed-off-by: Lars Hjemli --- cgit.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'cgit.h') diff --git a/cgit.h b/cgit.h index 4c854ea..893231d 100644 --- a/cgit.h +++ b/cgit.h @@ -207,7 +207,20 @@ struct cgit_page { char *statusmsg; }; +struct cgit_environment { + char *cgit_config; + char *http_host; + char *https; + char *path_info; + char *query_string; + char *request_method; + char *script_name; + char *server_name; + char *server_port; +}; + struct cgit_context { + struct cgit_environment env; struct cgit_query qry; struct cgit_config cfg; struct cgit_repo *repo; -- cgit 1.4.1 From 8b2252b0b61617e9de9d9e9ba743881ad62523af Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 10 Aug 2009 09:20:17 +0200 Subject: ui-shared: add support for NO_HTTP=1/--nohttp cgit_print_http_headers() used to do nothing if 'embedded' was specified in cgitrc, but that was wrong - we never want to skip the headers when invoked as a CGI app. Sadly, there's no easy way to detect if we're invoked as a CGI app or if we're invoked by another CGI app, so for the latter case cgit needs to be invoked with either --nohttp on the command line or NO_HTTP=1 in the environment. Signed-off-by: Lars Hjemli --- cgit.c | 4 ++++ cgit.h | 1 + ui-shared.c | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) (limited to 'cgit.h') diff --git a/cgit.c b/cgit.c index a92383d..36777b5 100644 --- a/cgit.c +++ b/cgit.c @@ -253,6 +253,7 @@ static void prepare_context(struct cgit_context *ctx) ctx->env.cgit_config = xstrdupn(getenv("CGIT_CONFIG")); ctx->env.http_host = xstrdupn(getenv("HTTP_HOST")); ctx->env.https = xstrdupn(getenv("HTTPS")); + ctx->env.no_http = xstrdupn(getenv("NO_HTTP")); ctx->env.path_info = xstrdupn(getenv("PATH_INFO")); ctx->env.query_string = xstrdupn(getenv("QUERY_STRING")); ctx->env.request_method = xstrdupn(getenv("REQUEST_METHOD")); @@ -445,6 +446,9 @@ static void cgit_parse_args(int argc, const char **argv) if (!strcmp(argv[i], "--nocache")) { ctx.cfg.nocache = 1; } + if (!strcmp(argv[i], "--nohttp")) { + ctx.env.no_http = "1"; + } if (!strncmp(argv[i], "--query=", 8)) { ctx.qry.raw = xstrdup(argv[i]+8); } diff --git a/cgit.h b/cgit.h index 893231d..d90ccdc 100644 --- a/cgit.h +++ b/cgit.h @@ -211,6 +211,7 @@ struct cgit_environment { char *cgit_config; char *http_host; char *https; + char *no_http; char *path_info; char *query_string; char *request_method; diff --git a/ui-shared.c b/ui-shared.c index 538ddda..4175bd8 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -455,7 +455,7 @@ void cgit_print_age(time_t t, time_t max_relative, char *format) void cgit_print_http_headers(struct cgit_context *ctx) { - if (ctx->cfg.embedded) + if (ctx->env.no_http && !strcmp(ctx->env.no_http, "1")) return; if (ctx->page.status) -- cgit 1.4.1 d0751c0b3e7895f3f799fe080352b&follow=1'>Add I've Got a Time BombJune McEnroe What a relief after 3 unbearably straight and awful books in a row. A wonderful mess. 2022-09-02Update "Care" with initial electrolysis reportJune McEnroe 2022-08-17Add The Book of Form and EmptinessJune McEnroe There are some nice things in here that I would really like in any other book, but not this one. 2022-08-15Load dates from ~/.config/when/datesJune McEnroe 2022-08-15Allow names with prefixes of months and daysJune McEnroe 2022-08-15Add named dates to whenJune McEnroe 2022-08-14Remove tweets text fileJune McEnroe Such link rot. 2022-08-09Fix all copyright noticesJune McEnroe 2022-08-04Add Conversations With FriendsJune McEnroe The better of the two, but largely the same. I feel like these books are a bit too autobiographical, but I don't know if I'm allowed to accuse an author of that. My real problem is that I read these books as largely uncritical of their characters. They behave in nonsense ways, are mostly uncritical of their own behaviour, and don't really have arcs of growth or change. I suppose this book had a bit of one, but only in the last two chapters. 2022-07-30Add Normal PeopleJune McEnroe Unbearably straight. Eyerolls and sighs per page off the charts. Shout out to Joanna, I guess. I kinda like the lack of quotation marks though to be honest. After half of the Ruth Ozeki novel and now this, I need to get back to some genre fiction. 2022-07-26Rewrite glitch from new pngoJune McEnroe 2022-07-26Update Care with time-to-ID and piercingsJune McEnroe 2022-07-26Add -w to upJune McEnroe 2022-07-13Set push.autoSetupRemoteJune McEnroe 2022-07-08Remove TOURJune McEnroe There is not that much distinct stuff here anymore. 2022-07-03Add The Bone Shard EmperorJune McEnroe Suffers a little bit from middle book but I really enjoyed it. Read it faster than the first one too, despite its length. 2022-06-25Bump xterm font size to 12June McEnroe 2022-06-10Handle subshells (and functions) inside substitutionsJune McEnroe 2022-06-10Switch to jorts Install scriptJune McEnroe 2022-06-08Indicate if still reading or no resultsJune McEnroe 2022-06-08Add Maiden, Mother, CroneJune McEnroe Mixed bag like most collections of short stories. Some of them are pretty good. The author of the worst written story also has the worst written bio. 2022-06-05FIRST SHOW IN 2.5 YEARS BABEY!!!June McEnroe 2022-06-03Set line number on File linesJune McEnroe 2022-06-03Stop polling stdin after EOFJune McEnroe 2022-06-02Set TABSIZE=4June McEnroe Absolutely indiscriminately. 2022-06-02Do basic match highlightingJune McEnroe 2022-06-02Clean up parsing a littleJune McEnroe 2022-06-02Don't duplicate path stringJune McEnroe 2022-06-02Use stderr instead of /dev/tty, realloc buffer if lines too longJune McEnroe For some reason I haven't been able to figure out, trying to poll /dev/tty returns POLLNVAL (and this was using 100% CPU looping), but using stderr instead works fine. 2022-06-02Add initial working version of qfJune McEnroe 2022-05-29Set prompt for okshJune McEnroe