From 927b0ae30c84fbfce877e35415681dce6eba0229 Mon Sep 17 00:00:00 2001
From: Lukas Fleischer <lfleischer@lfos.de>
Date: Thu, 29 Sep 2016 08:38:45 +0200
Subject: Simplify http_parse_querystring()

Instead of reimplementing URL parameter parsing from scratch, use
url_decode_parameter_name() and url_decode_parameter_value() which are
already provided by Git.

Also, change the return type of http_parse_querystring() to void since
its only caller already ignores the return value.

Signed-off-by: Lukas Fleischer <lfleischer@lfos.de>
---
 html.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'html.h')

diff --git a/html.h b/html.h
index c72e845..1b24e55 100644
--- a/html.h
+++ b/html.h
@@ -32,6 +32,6 @@ extern void html_link_close(void);
 extern void html_fileperm(unsigned short mode);
 extern int html_include(const char *filename);
 
-extern int http_parse_querystring(const char *txt, void (*fn)(const char *name, const char *value));
+extern void http_parse_querystring(const char *txt, void (*fn)(const char *name, const char *value));
 
 #endif /* HTML_H */
-- 
cgit 1.4.1

bin/man1/glitch.1?follow=1'>log</a> <a href='/src/tree/bin/man1/glitch.1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684'>tree</a> <a href='/src/commit/bin/man1/glitch.1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;follow=1'>commit</a> <a href='/src/diff/bin/man1/glitch.1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;follow=1'>diff</a></td><td class='form'><form class='right' method='get' action='/src/log/bin/man1/glitch.1'>
<input type='hidden' name='id' value='de770daf93c2269e02b1f9ce3386e0ec85c05684'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/src/log/?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;follow=1'>root</a>/<a href='/src/log/bin?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;follow=1'>bin</a>/<a href='/src/log/bin/man1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;follow=1'>man1</a>/<a href='/src/log/bin/man1/glitch.1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;follow=1'>glitch.1</a> (<a href='/src/log/bin/man1/glitch.1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th></th><th class='left'>Commit message (<a href='/src/log/bin/man1/glitch.1?id=de770daf93c2269e02b1f9ce3386e0ec85c05684&amp;showmsg=1&amp;follow=1'>Expand</a>)</th><th class='left'>Author</th></tr>
<tr><td><span title='2020-06-16 22:57:58 -0400'>2020-06-16</span></td><td><a href='/src/commit/home/.shrc?id=71809d52611ffe403790684ad9b3bf777b81c62a&amp;follow=1'>Add LC_COLLATE=C to ls alias</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-11 19:01:02 -0400'>2020-06-11</span></td><td><a href='/src/commit/bin/pbd.c?id=ffc19e2ee1b6eef4ac08e85fc7ef2e98ec32db9c&amp;follow=1'>Fix pbd for neovim</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-11 17:07:12 -0400'>2020-06-11</span></td><td><a href='/src/commit/home/.shrc?id=bec5687922a9686e843437f9204a22d2bb31cde8&amp;follow=1'>Alias sudo=doas if available</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-11 15:29:13 -0400'>2020-06-11</span></td><td><a href='/src/commit/home/.ssh/config?id=76cccb39d1a8157292a4820ce07858fec4e5848e&amp;follow=1'>Add all VMs to ssh config</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 17:56:33 -0400'>2020-06-08</span></td><td><a href='/src/commit/bin/relay.c?id=1ca30cd7b19b5e9d46abab3cfc78ed286a873495&amp;follow=1'>Add additional permission for linking with LibreSSL</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 16:46:02 -0400'>2020-06-08</span></td><td><a href='/src/commit/bin/1sh/var.c?id=5469e127e6f872f7a61f76ccda8d96e686eae7c4&amp;follow=1'>Replace __DECONST with regular casts</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 16:46:02 -0400'>2020-06-08</span></td><td><a href='/src/commit/bin/1sh/test.c?id=506c330d35400bfcfbec6b5806e49c89c31c1e4e&amp;follow=1'>Replace __printflike with __attribute__((format(printf, ...)))</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 16:46:02 -0400'>2020-06-08</span></td><td><a href='/src/commit/bin/1sh/trap.h?id=3177ae700a2ba82ef2282ddc5404d8de8646cd57&amp;follow=1'>Replace __dead2 with __attribute__((noreturn))</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 16:46:02 -0400'>2020-06-08</span></td><td><a href='/src/commit/bin/1sh/var.c?id=3e530e05790261b3b97aeee69a5c7d40957ca9d4&amp;follow=1'>Replace __FBSDID macros with comments</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 16:35:58 -0400'>2020-06-08</span></td><td><a href='/src/commit/bin/1sh/histedit.c?id=5d1059241f9ba7a0be0852dc98a307b9fa560c47&amp;follow=1'>Remove reference to FreeBSD-specific libedit hack</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-08 15:48:12 +0000'>2020-06-08</span></td><td><a href='/src/commit/www/git.causal.agency/about-filter.sh?id=95da16bf555d6e9ea9b94e44b6b2a38253f166d8&amp;follow=1'>Prefix mandoc with exec in about-filter</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-07 15:14:07 -0400'>2020-06-07</span></td><td><a href='/src/commit/bin/1sh/mktokens?id=052c207a9ca2b478f957a811a761e45c7aef680f&amp;follow=1'>Remove mktemp options from mkbuiltins, mktokens</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-07 15:04:16 -0400'>2020-06-07</span></td><td><a href='/src/commit/bin/pngo.c?id=5b1657f1d6f3e7f6f8f75d3601e57c566ac6a3bb&amp;follow=1'>Cast z_stream fields to size_t</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-07 14:40:04 -0400'>2020-06-07</span></td><td><a href='/src/commit/bin/pngo.c?id=d9e6f6b9af36a5f20a12e39f6f98ba0abe99d996&amp;follow=1'>Call static_assert by _Static_assert</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-07 14:34:29 -0400'>2020-06-07</span></td><td><a href='/src/commit/install.sh?id=3dbba9a058ddd604c714d12e1f53977e747bb58a&amp;follow=1'>Add OpenBSD to install.sh</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-03 11:56:03 -0400'>2020-06-03</span></td><td><a href='/src/commit/txt/books.txt?id=59755ec4ec87e8b6a638d9a86af3c5a26d891f38&amp;follow=1'>Add The Song of Achilles</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-06-01 15:52:22 -0400'>2020-06-01</span></td><td><a href='/src/commit/bin/man1/ever.1?id=c33f7d27df55d454029f2c9542ebe7fc46c0e368&amp;follow=1'>Allow redirecting input in ever</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-05-31 14:13:42 -0400'>2020-05-31</span></td><td><a href='/src/commit/bin/c.sh?id=d92bdfe4bf1ac7cc0804aa2a06a4748cee38fc5d&amp;follow=1'>Add %c conversion to c script</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-05-31 13:13:52 -0400'>2020-05-31</span></td><td><a href='/src/commit/bin/README.7?id=23d2de658ec0f99dbde8cb0d07e71acb15f853ab&amp;follow=1'>Add c script to README</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-05-31 13:12:23 -0400'>2020-05-31</span></td><td><a href='/src/commit/bin/man1/c.1?id=7daba199347fce96e47b7c59b9c008801f2668ec&amp;follow=1'>Add c script</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-05-31 02:17:51 -0400'>2020-05-31</span></td><td><a href='/src/commit/www/text.causal.agency/005-testing-c.7?id=cdd81f368de8988efd9c018df1b29e8d10f03ae3&amp;follow=1'>Update mdoc source URLs</a></td><td>June McEnroe</td></tr>
<tr><td><span title='2020-05-26 11:12:08 -0400'>2020-05-26</span></td><td><a href='/src/commit/etc/psf/serif8x16.psf?id=4caf14dfccc5ca6538eb1118f20977cff776f766&amp;follow=1'>Remove unfinished PSF fonts</a></td><td>June McEnroe