From 64f30688faef0876641a8e0e4f26b5c673c291d4 Mon Sep 17 00:00:00 2001 From: John Keeping Date: Sun, 14 Apr 2013 17:07:41 +0100 Subject: t0109: test more URLs In order to ensure that we don't access $HOME at some point after initial startup when rendering a specific view, run the strace test on a range of different pages. This ensures that we don't end up reading a configuration later for some specific view. Signed-off-by: John Keeping --- tests/t0109-gitconfig.sh | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) (limited to 'tests') diff --git a/tests/t0109-gitconfig.sh b/tests/t0109-gitconfig.sh index f64e691..24b2942 100755 --- a/tests/t0109-gitconfig.sh +++ b/tests/t0109-gitconfig.sh @@ -9,17 +9,33 @@ test -n "$(which strace 2>/dev/null)" || { exit } -test_expect_success 'no access to $HOME' ' +test_no_home_access () { non_existant_path="/path/to/some/place/that/does/not/possibly/exist" while test -d "$non_existant_path"; do non_existant_path="$non_existant_path/$(date +%N)" - done + done && strace \ -E HOME="$non_existant_path" \ -E CGIT_CONFIG="$PWD/cgitrc" \ - -E QUERY_STRING="url=foo/commit" \ + -E QUERY_STRING="url=$1" \ -e access -f -o strace.out cgit && test_must_fail grep "$non_existant_path" strace.out -' +} + +function test_no_home_access_success() { + test_expect_success "do not access \$HOME: $1" " + test_no_home_access '$1' + " +} + +test_no_home_access_success +test_no_home_access_success foo +test_no_home_access_success foo/refs +test_no_home_access_success foo/log +test_no_home_access_success foo/tree +test_no_home_access_success foo/tree/file-1 +test_no_home_access_success foo/commit +test_no_home_access_success foo/diff +test_no_home_access_success foo/patch test_done -- cgit 1.4.1 ion>
path: root/Makefile (unfollow)
Commit message (Collapse)Author
2020-08-15Clarify restart interval in catsitd manualJune McEnroe
2020-08-15Fix resetting restart interval with explicit restartJune McEnroe
2020-08-15Add reset interval after which restart interval is resetJune McEnroe
2020-08-15Log when service name pattern doesn't matchJune McEnroe
2020-08-15Add FreeBSD rc scriptJune McEnroe
I'm expecting to also have an OpenBSD rc script.
2020-08-15Call setproctitle with number of servicesJune McEnroe
2020-08-15Rename project to catsitJune McEnroe
2020-08-15Use only LOG_NOTICE and LOG_WARNINGJune McEnroe
These are the two priorities that go to a normal place (/var/log/messages) by default.
2020-08-15Make log messages consistentJune McEnroe
2020-08-15Remove closelog callJune McEnroe
It's unclear whether closelog is really safe to call in pre-exec context, so just trust that the log is opened with CLOEXEC.
2020-08-15Implement service statusJune McEnroe
2020-08-15Parse control commandsJune McEnroe
2020-08-15Read service pipesJune McEnroe
Changed line reading functions to return const char * because modifying the strings by adding '\0' into them screws up the following call.
2020-08-15Implement non-blocking line-buffered readingJune McEnroe
2020-08-15Generate tags fileJune McEnroe
2020-08-15Just use CLOCK_MONOTONIC and clean up includesJune McEnroe
CLOCK_MONOTONIC exists everywhere.
2020-08-15Reap childrenJune McEnroe
2020-08-14Implement serviceSignal, serviceStop, serviceRestartJune McEnroe
2020-08-14Reset restartInterval and restartDeadline on startJune McEnroe
2020-08-14Switch to timespec for timeoutsJune McEnroe
Can be passed to ppoll(2) directly.
2020-08-14Implement serviceStartJune McEnroe
2020-08-14Flesh out Service structJune McEnroe
2020-08-14Build environment for servicesJune McEnroe
2020-08-14Implement spawntab parsingJune McEnroe
2020-08-14Open syslog, daemonize, write PIDJune McEnroe
2020-08-14Implement user and group lookupJune McEnroe
2020-08-14Add install targetJune McEnroe
2020-08-14Add spawnd skeletonJune McEnroe