From b9053a4ff04fef90d1b9ab3f813ae3fcee63a8c3 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 1 Dec 2008 21:50:19 +0100 Subject: ui-shared: exploit snapshot dwimmery in cgit_print_snapshot_links Since we know that ui-snapshot.c is able to extract the revision from the filename, there's no longer necessary to specify the revision with a 'id' querystring argument. Signed-off-by: Lars Hjemli --- ui-shared.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'ui-shared.c') diff --git a/ui-shared.c b/ui-shared.c index 224e5f3..c4a506e 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -707,8 +707,7 @@ void cgit_print_snapshot_links(const char *repo, const char *head, continue; filename = fmt("%s-%s%s", cgit_repobasename(repo), hex, f->suffix); - cgit_snapshot_link(filename, NULL, NULL, (char *)head, - (char *)hex, filename); + cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename); html("
"); } } -- cgit 1.4.1 From c57aceb1d2f1a7d9fd3218fc8c6e9ea01b2952d2 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 1 Dec 2008 21:58:59 +0100 Subject: ui-shared: shorten the sha1 printed by cgit_object_link Such links was printed as the object type followed by the objects complete sha1. We still use the complete sha1 in the link but we no longer show it in all its glory; only the first 10 hex chars are printed. Signed-off-by: Lars Hjemli --- ui-shared.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'ui-shared.c') diff --git a/ui-shared.c b/ui-shared.c index c4a506e..9319881 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -365,11 +365,14 @@ void cgit_patch_link(char *name, char *title, char *class, char *head, void cgit_object_link(struct object *obj) { - char *page, *rev, *name; + char *page, *shortrev, *fullrev, *name; + fullrev = sha1_to_hex(obj->sha1); + shortrev = xstrdup(fullrev); + shortrev[10] = '\0'; if (obj->type == OBJ_COMMIT) { - cgit_commit_link(fmt("commit %s", sha1_to_hex(obj->sha1)), NULL, NULL, - ctx.qry.head, sha1_to_hex(obj->sha1)); + cgit_commit_link(fmt("commit %s...", shortrev), NULL, NULL, + ctx.qry.head, fullrev); return; } else if (obj->type == OBJ_TREE) page = "tree"; @@ -377,9 +380,8 @@ void cgit_object_link(struct object *obj) page = "tag"; else page = "blob"; - rev = sha1_to_hex(obj->sha1); - name = fmt("%s %s", typename(obj->type), rev); - reporevlink(page, name, NULL, NULL, ctx.qry.head, rev, NULL); + name = fmt("%s %s...", typename(obj->type), shortrev); + reporevlink(page, name, NULL, NULL, ctx.qry.head, fullrev, NULL); } void cgit_print_date(time_t secs, char *format, int local_time) -- cgit 1.4.1 /log/www/text.causal.agency/009-casual-update.7?id=83df957419b317baf06ed958250cb5244daabad7&showmsg=1&follow=1'>Expand)Author 2020-12-20Depend on rfc-index.txt.gz in MakefileJune McEnroe 2020-12-19Convert :RFC number to numberJune McEnroe 2020-12-19Move :RFC to plugin scriptJune McEnroe 2020-12-19Sort RFC tags fileJune McEnroe 2020-12-19Open rfc-index.txt for :RFC without argumentJune McEnroe 2020-12-19Include rfc-index.txt in RFC syncJune McEnroe 2020-12-18Add :RFC vim command to view IETF RFCsJune McEnroe 2020-12-18Add scripts to download, compress and tag IETF RFCsJune McEnroe 2020-12-18Fix bibsort name sorting for middle names, trailing titlesJune McEnroe 2020-12-15Add bibsortJune McEnroe 2020-12-08Add modem -r flag to set baud rateJune McEnroe 2020-12-07Clean up variable expansions in c.shJune McEnroe 2020-12-06Add I Feel It AllJune McEnroe 2020-12-05Handle const strings in c -eJune McEnroe 2020-12-05Disable mouse in htopJune McEnroe 2020-12-03Note lack of macro expansions in Q(...)June McEnroe 2020-12-02Fix missing "to" in "hot tips"June McEnroe 2020-12-02Publish "hot tips"June McEnroe 2020-11-26Publish "Inability"June McEnroe 2020-11-26Render content into atom feedJune McEnroe 2020-11-26Update plan with different things I won't doJune McEnroe 2020-11-19Add "Come On Petunia"June McEnroe 2020-11-13Add x4 to LESSJune McEnroe 2020-11-04Remove modified sensitivity settingsJune McEnroe 2020-10-29Remove editJune McEnroe 2020-10-27Switch gr alias back to git rebaseJune McEnroe 2020-10-27Allow cd host: to cd to same path over sshJune McEnroe 2020-10-27Use SendEnv for cd host:pathJune McEnroe 2020-10-27Allow cd host:path over sshJune McEnroe 2020-10-07Use mandoc -T utf8 for text.June McEnroe 2020-09-20Add The Awakened KingdomJune McEnroe 2020-09-12Move /opt/local back, cheat port select to use system manJune McEnroe 2020-09-12Move /opt/local behind /usr againJune McEnroe 2020-09-12Enable toc in cgit renderings of man pagesJune McEnroe 2020-09-11Install mandoc on macOSJune McEnroe 2020-09-11Rewrite install script yet againJune McEnroe 2020-09-11Remove NetBSD from install scriptJune McEnroe 2020-09-11Use MacPorts rather than pkgsrcJune McEnroe 2020-09-11Add debian VM name to sshJune McEnroe 2020-09-11Add influencer tweetJune McEnroe 2020-09-10Add The Kingdom of GodsJune McEnroe 2020-09-07Add SunglassesJune McEnroe 2020-09-06Add Between the BreathsJune McEnroe 2020-09-04Open /dev/tty in nudgeJune McEnroe 2020-09-04Add nudgeJune McEnroe 2020-09-03Build fbclock with -lzJune McEnroe 2020-08-29Add tweets from retweetsJune McEnroe