From 2216fd6472fe183439df1a39c1c06974abc3f150 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 3 Dec 2007 00:39:20 +0100 Subject: Compare string lengths when parsing the snapshot mask We used to rely on the result from strncmp() without comparing the length of the strings involved. Even worse, any single-character format specifier would enable zip-format due to the optional '.'-prefix since the length of the mask then would become zero. Noticed-by: Evan Martin Signed-off-by: Lars Hjemli --- ui-snapshot.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'ui-snapshot.c') diff --git a/ui-snapshot.c b/ui-snapshot.c index 4d1aa88..dfedd8f 100644 --- a/ui-snapshot.c +++ b/ui-snapshot.c @@ -130,7 +130,7 @@ int cgit_parse_snapshots_mask(const char *str) { const struct snapshot_archive_t* sat; static const char *delim = " \t,:/|;"; - int f, tl, rv = 0; + int f, tl, sl, rv = 0; /* favor legacy setting */ if(atoi(str)) @@ -142,8 +142,9 @@ int cgit_parse_snapshots_mask(const char *str) break; for(f=0; fsuffix, str, tl) && - strncmp(sat->suffix+1, str, tl-1))) { + sl = strlen(sat->suffix); + if((tl == sl && !strncmp(sat->suffix, str, tl)) || + (tl == sl-1 && !strncmp(sat->suffix+1, str, tl-1))) { rv |= sat->bit; break; } -- cgit 1.4.1 fdf0c39ee01d0eff387a1da9dc8980f&follow=1'>diff
Commit message (Collapse)Author
2012-02-25Add ,z mapping to toggle spellJune McEnroe
2012-02-13Add badwolf colorschemeJune McEnroe
2012-02-11Customize C/C++ indentationJune McEnroe
2012-02-07Update Powerline to 'develop' branchJune McEnroe
2012-02-07Add Solarized colorschemeJune McEnroe
2012-02-07Add back set nocompatible, even though it seemed to end up set anywayJune McEnroe
2012-02-05Update jellybeansJune McEnroe
2012-02-02Update itchy.vimJune McEnroe
2012-02-02Add mapping to toggle relative/absolute numberingJune McEnroe
2012-02-02Add itchy.vimJune McEnroe
2012-02-01Revert "Add ShowMarks plugin"June McEnroe
This reverts commit 28cf15ba0309361cb972012bb3bdad62423f401d.
2012-02-01Add ShowMarks pluginJune McEnroe
2012-02-01Update Vim-Tomorrow-ThemeJune McEnroe
2012-02-01Add vim-markdownJune McEnroe
2012-02-01Add tabular.vimJune McEnroe
2012-02-01Update Vim-Tomorrow-ThemeJune McEnroe
PS. Chris Kempson is a jerk.
2012-01-30Disable menu bar in GVimJune McEnroe
2012-01-30Set shiftwidth to 4 for LuaJune McEnroe
2012-01-29Don't show Syntastic errors automaticallyJune McEnroe
2012-01-28Update to Quicktask 1.1June McEnroe
2012-01-22Use space-test branch of quicktaskJune McEnroe
2012-01-22Enable syntax-based foldingJune McEnroe
2012-01-22Update quicktaskJune McEnroe
2012-01-22Revert "Add AutoClose"June McEnroe
This reverts commit 39cfdd62ba82f93f68a2b5fa7b5771303d8b9dee. This fixes the delay when leaving insert mode
2012-01-22Revert "Disable powerline for now"June McEnroe
This reverts commit fa48f5965c57272e616721d92475cd2f1e35f667.
2012-01-22Revert "Add VCS repo directories to wildignore"June McEnroe
This reverts commit 41cb1db33ba7b64d8af63bf55bb82f7e8a617518. This fixes not being able to commit with vim-fugitive
2012-01-22Disable powerline for nowJune McEnroe
2012-01-22Update some pluginsJune McEnroe
2012-01-22Add VCS repo directories to wildignoreJune McEnroe
2012-01-22Map ,e and ,b to CtrlP file and buffer respectivelyJune McEnroe
2012-01-22Add vim-spaceJune McEnroe
2012-01-22Add AutoCloseJune McEnroe
2012-01-22Add binding for GundoJune McEnroe
2012-01-22Add GundoJune McEnroe
2012-01-22Add Jellybeans colorschemeJune McEnroe
2012-01-22Add syntasticJune McEnroe
2012-01-21Add PowerlineJune McEnroe
2012-01-21Add quicktaskJune McEnroe
2012-01-15Moved comments out of mapsJune McEnroe
2012-01-14Disable scrollbarsJune McEnroe