From c22e9cc693a6271533740abd9be1bf918a40b0b3 Mon Sep 17 00:00:00 2001
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 26 Mar 2018 18:33:49 +0800
Subject: redir: Fix typo in noclobber code

The noclobber code has a typo in it that causes it to fail.  This
patch fixes it.

Reported-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---
 src/redir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/redir.c b/src/redir.c
index f96a76b..71b0f77 100644
--- a/src/redir.c
+++ b/src/redir.c
@@ -192,7 +192,7 @@ openredirect(union node *redir)
 			} else if (!S_ISREG(sb.st_mode)) {
 				if ((f = open64(fname, O_WRONLY, 0666)) < 0)
 					goto ecreate;
-				if (fstat64(f, &sb) < 0 && S_ISREG(sb.st_mode)) {
+				if (!fstat64(f, &sb) && S_ISREG(sb.st_mode)) {
 					close(f);
 					errno = EEXIST;
 					goto ecreate;
-- 
cgit 1.4.1

td></tr>
<tr><td class='sub'>dontfiles
</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/src/'>summary</a> <a href='/src/refs/?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d'>refs</a> <a class='active' href='/src/log/bin/glitch.c?showmsg=1&amp;follow=1'>log</a> <a href='/src/tree/bin/glitch.c?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d'>tree</a> <a href='/src/commit/bin/glitch.c?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;follow=1'>commit</a> <a href='/src/diff/bin/glitch.c?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;follow=1'>diff</a></td><td class='form'><form class='right' method='get' action='/src/log/bin/glitch.c'>
<input type='hidden' name='id' value='2d87b53a18d48e9d8346c8b352aea5f2096a459d'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/src/log/?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;showmsg=1&amp;follow=1'>root</a>/<a href='/src/log/bin?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;showmsg=1&amp;follow=1'>bin</a>/<a href='/src/log/bin/glitch.c?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;showmsg=1&amp;follow=1'>glitch.c</a> (<a href='/src/log/bin/glitch.c?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;showmsg=1'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th></th><th class='left'>Commit message (<a href='/src/log/bin/glitch.c?id=2d87b53a18d48e9d8346c8b352aea5f2096a459d&amp;follow=1'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span class='age-hours' title='2024-06-10 14:21:45 -0400'>12 hours</span></td><td class='logsubject'><a href='/src/commit/txt/books.txt?id=013264d92bc84a8a2a133d9b55b6820fcad44806&amp;follow=1'>Add The Girl Who Was Convinced...</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
Not much there. The illustrations are very nice though.


</td></tr>
<tr class='logheader'><td><span class='age-hours' title='2024-06-09 19:07:18 -0400'>31 hours</span></td><td class='logsubject'><a href='/src/commit/www/photo.causal.agency/2024-05-31/IMG_2114.txt?id=5eea09d6bd3d109dffc48678600d997b42699788&amp;follow=1'>Add photos from May 31</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span class='age-hours' title='2024-06-09 18:57:02 -0400'>32 hours</span></td><td class='logsubject'><a href='/src/commit/www/photo.causal.agency/generate.sh?id=6f35229b87e64472805ba83e70bac5d8f90cb3e0&amp;follow=1'>Use monospace on photo pages</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span class='age-hours' title='2024-06-09 18:48:15 -0400'>32 hours</span></td><td class='logsubject'><a href='/src/commit/www/photo.causal.agency/generate.sh?id=2df9d0291f9451fd603f102778abf64a4d62f977&amp;follow=1'>Put lens and (future) film at the tops of photo pages</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span title='2024-05-22 12:16:41 -0400'>2024-05-22</span></td><td class='logsubject'><a href='/src/commit/bin/xx.c?id=625662a5c1cbb71cf37653df1f31cd60c48b18ae&amp;follow=1'>Remove use of sysexits.h</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span title='2024-05-22 11:55:53 -0400'>2024-05-22</span></td><td class='logsubject'><a href='/src/commit/www/photo.causal.agency/2024-05-06/IMG_2015.txt?id=00e1552bfe74992ccd5653a738a984e47bb2699c&amp;follow=1'>Add photo descriptions from 05-03 and 05-06</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span title='2024-05-21 17:07:53 -0400'>2024-05-21</span></td><td class='logsubject'><a href='/src/commit/bin/when.y?id=cc8dba0836353aa5ea1096d526daae9129da3b5e&amp;follow=1'>Fix = precedence in when</a></td><td>June McEnroe