summary refs log tree commit diff
path: root/rc.d (unfollow)
Commit message (Expand)Author
2020-08-10Mention LibreTLS in README 1.5June McEnroe
2020-08-01Check return value of asprintfJune McEnroe
2020-07-24Don't bother with --sysconfdirJune McEnroe
2020-07-24Use asprintf to concatenate queryJune McEnroe
2020-07-24Fix select #defineJune McEnroe
2020-07-24Rewrite configure script for all platforms, add OpenBSDJune McEnroe
2020-07-21Add scooper to READMEJune McEnroe
2020-07-19Add -U scooper-url option to make scooper linksJune McEnroe
2020-07-11Replace time index with (context, time) index 1.4p1June McEnroe
2020-07-08Delay creating eventsTime index when migration from v2 1.4June McEnroe
2020-07-08Add link to "IRC Suite" post in READMEJune McEnroe
2020-07-08Fix -D nowJune McEnroe
2020-07-08Convert timestamps to unix epoch timeJune McEnroe
2020-07-07Allocate enough bind space for :open and :closeJune McEnroe
2020-07-07Create index on events.timeJune McEnroe
2020-07-07Use >= and < on events.time for -DJune McEnroe
2020-07-07Only join FTS table when FTS query is presentJune McEnroe
2020-06-24Bump ParamCap to 254June McEnroe
2020-06-12Remove RPL_MOTDSTART handlerJune McEnroe
2020-06-08Add additional permission for linking with LibreSSLJune McEnroe
2020-05-22Perform all migrations in one transaction 1.3June McEnroe
2020-05-21Clean up unscoop manual pageJune McEnroe
2020-05-21Fix search expression appendJune McEnroe
2020-05-21Fix dbPrepare errx callJune McEnroe
2020-05-21Add only the necessary expressions to scoop's queryJune McEnroe
2020-05-21Explicitly set stdout line buffered when pagingJune McEnroe
2020-05-21Do not sort results in scoop by defaultJune McEnroe
2020-05-21Expand and clarify documentationJune McEnroe
2020-05-21Execute PAGER with the SHELLJune McEnroe
2020-05-21Automatically perform database migrations in litterboxJune McEnroe
2020-05-20Don't install rc scripts on other platformsJune McEnroe
2020-05-20Rewrite build and install like pounce 1.3June McEnroe
2020-05-20Update email addressesJune McEnroe
2020-04-23Call updateConsumer from handleError 1.2p1June McEnroe
2020-04-20Use . as ${LDLIBS.$@} separatorJune McEnroe
2020-04-05Error on invalid ISUPPORT values 1.2June McEnroe
2020-04-05Only set RCS on FreeBSDJune McEnroe
2020-04-05Log bans and unbansJune McEnroe
2020-04-05Parse mode types from ISUPPORTJune McEnroe
2020-04-05Add unscoop matchers for ban/unban eventsJune McEnroe
2020-04-05Check unscoop regexps with make testJune McEnroe
2020-04-05Add unscoop -n flag for checking regexpsJune McEnroe
2020-04-05Add Ban and Unban event typesJune McEnroe
2020-04-02Update styleJune McEnroe
2020-03-31Update unscoop catgirl matchersJune McEnroe
2020-03-31Fix writing verbose to stderrJune McEnroe
2020-03-02Include <>/-/* around nicks in scoop coloring 1.1June McEnroe
2020-03-02Replace .mk files with configure scriptJune McEnroe
2020-02-28Implement the causal.agency/consumer capabilityJune McEnroe
2020-02-22Include <>/-/* around nicks in coloringJune McEnroe
idden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu