pounce, branch 1.0p1

Link calico with libcrypto on Linux

2019-11-21T21:45:40+00:00

For the strlcpy implementation.

Fix wordcmp return value when the words have differing lengths

2019-11-21T21:26:43+00:00

Otherwise, the result of strncmp gets converted size_t, since size_t has greater rank than int. Since wordcmp is only ever used as a boolean condition, this poses no real issue, but presumably, it is meant to behave like the other *cmp function and return a value less than, equal to, or greater than 0 depending on the result of the comparison.

Declare globals as extern in headers, and define in source file

2019-11-21T21:26:37+00:00

Otherwise, each source file that includes the header gets its own definition, and according to the C standard (C99 6.9p5): > If an identifier declared with external linkage is used in an > expression (other than as part of the operand of a sizeof operator > whose result is an integer constant), somewhere in the entire > program there shall be exactly one external definition for the > identifier Most compilers use the .bss section for zero data, but if it uses .data instead, or if -Wl,--warn-common is used, this will cause a linking error.

Zero temporary SASL PLAIN buffer

2019-11-21T21:26:08+00:00

Use a static buffer for plainBase64

2019-11-21T21:25:09+00:00

Use a fixed buffer size for SASL PLAIN authentication

2019-11-21T21:14:10+00:00

handleAuthenticate only sends a single AUTHENTICATE message, so according to https://ircv3.net/specs/extensions/sasl-3.1.html, its maximum length is 399. So, we know that the authentication string can be at most 299 bytes.

Avoid a couple VLAs with constant size

2019-11-20T20:23:46+00:00

These are really just regular arrays masquerading as VLAs.

client: Include time.h for gmtime and strftime

2019-11-20T19:54:32+00:00

Use strlcpy for sun_paths

2019-11-20T18:39:25+00:00

My understanding is that sun_path need not be nul-terminated, but I didn't notice that SUN_LEN actually requires it. > The length of UNIX-domain address, required by bind(2) and connect(2), > can be calculated by the macro SUN_LEN() defined in . The > sun_path field must be terminated by a NUL character to be used with > SUN_LEN(), but the terminating NUL is not part of the address. Thanks to Duncan Overbruck for the report.

Format milliseconds as int

2019-11-20T18:33:22+00:00

I don't know what I was thinking. I'm expecting a number less than 1000 of course that fits in int.