From 78a685fa2293b7797906d3225f7a302ed58ce79e Mon Sep 17 00:00:00 2001
From: Curtis McEnroe <june@causal.agency>
Date: Sat, 26 Oct 2019 16:38:36 -0400
Subject: Require PASS before USER

Prevent creating a ring consumer without authentication.
---
 client.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/client.c b/client.c
index f7fff33..198f1f6 100644
--- a/client.c
+++ b/client.c
@@ -114,9 +114,13 @@ static void handleUser(struct Client *client, struct Message *msg) {
 		client->error = true;
 		return;
 	}
-	client->consumer = ringConsumer(msg->params[0]);
-	client->need &= ~NeedUser;
-	sync(client);
+	if (client->need & NeedPass) {
+		passRequired(client);
+	} else {
+		client->need &= ~NeedUser;
+		client->consumer = ringConsumer(msg->params[0]);
+		sync(client);
+	}
 }
 
 static void handlePass(struct Client *client, struct Message *msg) {
-- 
cgit 1.4.1

ut type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>dontfiles
</td><td class='sub right'></td></tr></table>
<table class='tabs'><tr><td>
<a href='/src/'>summary</a> <a href='/src/refs/?id=424ba42885be864785de5f75c503393f1d467cda'>refs</a> <a class='active' href='/src/log/etc/CodeQWERTY.bundle/Contents?showmsg=1&amp;follow=1'>log</a> <a href='/src/tree/etc/CodeQWERTY.bundle/Contents?id=424ba42885be864785de5f75c503393f1d467cda'>tree</a> <a href='/src/commit/etc/CodeQWERTY.bundle/Contents?id=424ba42885be864785de5f75c503393f1d467cda&amp;follow=1'>commit</a> <a href='/src/diff/etc/CodeQWERTY.bundle/Contents?id=424ba42885be864785de5f75c503393f1d467cda&amp;follow=1'>diff</a></td><td class='form'><form class='right' method='get' action='/src/log/etc/CodeQWERTY.bundle/Contents'>
<input type='hidden' name='id' value='424ba42885be864785de5f75c503393f1d467cda'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/src/log/?id=424ba42885be864785de5f75c503393f1d467cda&amp;showmsg=1&amp;follow=1'>root</a>/<a href='/src/log/etc?id=424ba42885be864785de5f75c503393f1d467cda&amp;showmsg=1&amp;follow=1'>etc</a>/<a href='/src/log/etc/CodeQWERTY.bundle?id=424ba42885be864785de5f75c503393f1d467cda&amp;showmsg=1&amp;follow=1'>CodeQWERTY.bundle</a>/<a href='/src/log/etc/CodeQWERTY.bundle/Contents?id=424ba42885be864785de5f75c503393f1d467cda&amp;showmsg=1&amp;follow=1'>Contents</a> (<a href='/src/log/etc/CodeQWERTY.bundle/Contents?id=424ba42885be864785de5f75c503393f1d467cda&amp;showmsg=1'>unfollow</a>)</div><div class='content'><table class='list nowrap'><tr class='nohover'><th></th><th class='left'>Commit message (<a href='/src/log/etc/CodeQWERTY.bundle/Contents?id=424ba42885be864785de5f75c503393f1d467cda&amp;follow=1'>Collapse</a>)</th><th class='left'>Author</th></tr>
<tr class='logheader'><td><span title='2020-09-04 23:39:55 -0400'>2020-09-04</span></td><td class='logsubject'><a href='/src/commit/bin/nudge.c?id=d6cd53eb1c6465d4379eed417b18535740f8c3f3&amp;follow=1'>Open /dev/tty in nudge</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
This makes it work even when it's run connected to a pipe, i.e. as the
notify command of catgirl...


</td></tr>
<tr class='logheader'><td><span title='2020-09-04 18:41:04 -0400'>2020-09-04</span></td><td class='logsubject'><a href='/src/commit/bin/nudge.c?id=c738cb62a069f5b9dedde8730341edb45b7a3bbb&amp;follow=1'>Add nudge</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
</td></tr>
<tr class='logheader'><td><span title='2020-09-03 20:37:08 -0400'>2020-09-03</span></td><td class='logsubject'><a href='/src/commit/bin/Makefile?id=26ad6e3c7abee6aa8e30b47c201b18ce6ea9e19e&amp;follow=1'>Build fbclock with -lz</a></td><td>June McEnroe</td></tr>
<tr class='nohover-highlight'><td/><td colspan='3' class='logmsg'>
I guess this got lost somewhere, long ago...


</td></tr>
<tr class='logheader'><td><span title='2020-08-29 19:59:51 -0400'>2020-08-29</span></td><td class='logsubject'><a href='/src/commit/txt/tweets.txt?id=f4374920b41a968af9629f8980763f338b5f3e02&amp;follow=1'>Add tweets from retweets</a></td><td>June McEnroe