From f4b0d09e3f782511b99626104ca960dd5decd4b8 Mon Sep 17 00:00:00 2001 From: Michael Forney Date: Wed, 20 Nov 2019 01:22:06 -0800 Subject: Declare globals as extern in headers, and define in source file Otherwise, each source file that includes the header gets its own definition, and according to the C standard (C99 6.9p5): > If an identifier declared with external linkage is used in an > expression (other than as part of the operand of a sizeof operator > whose result is an integer constant), somewhere in the entire > program there shall be exactly one external definition for the > identifier Most compilers use the .bss section for zero data, but if it uses .data instead, or if -Wl,--warn-common is used, this will cause a linking error. --- bounce.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'bounce.c') diff --git a/bounce.c b/bounce.c index 908a1cb..d4b6175 100644 --- a/bounce.c +++ b/bounce.c @@ -41,6 +41,8 @@ #include "bounce.h" +bool verbose; + static void hashPass(void) { char *pass = getpass("Password: "); byte rand[12]; -- cgit 1.4.1