From 2574f08695df0ac9271e177201b4faf2130ceb01 Mon Sep 17 00:00:00 2001 From: "C. McEnroe" Date: Mon, 12 Apr 2021 21:18:42 +0000 Subject: Fix crash trying to print "this commit" on 404s For example any URL that starts with a real repo name but isn't valid. --- www/git.causal.agency/cgit/ui-shared.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/git.causal.agency/cgit/ui-shared.c b/www/git.causal.agency/cgit/ui-shared.c index d02b6c85..d7fa8b2a 100644 --- a/www/git.causal.agency/cgit/ui-shared.c +++ b/www/git.causal.agency/cgit/ui-shared.c @@ -896,7 +896,7 @@ void cgit_add_clone_urls(void (*fn)(const char *)) static int print_this_commit_option(void) { struct object_id oid; - if (get_oid(ctx.qry.head, &oid)) + if (!ctx.qry.head || get_oid(ctx.qry.head, &oid)) return 1; html_option(oid_to_hex(&oid), "this commit", ctx.qry.head); return 0; -- cgit 1.4.1