From 8ee3459cdb3152b9ef551c97041c725ae816977d Mon Sep 17 00:00:00 2001
From: Curtis McEnroe <june@causal.agency>
Date: Thu, 22 Nov 2018 16:05:51 -0500
Subject: Simplify edi file reading

---
 bin/edi/buffer.c | 13 ++++++++-----
 bin/edi/edi.h    |  1 +
 bin/edi/file.c   | 22 ++++++++++------------
 bin/edi/iter.c   |  1 +
 4 files changed, 20 insertions(+), 17 deletions(-)

(limited to 'bin')

diff --git a/bin/edi/buffer.c b/bin/edi/buffer.c
index a7ff74c9..311d88c0 100644
--- a/bin/edi/buffer.c
+++ b/bin/edi/buffer.c
@@ -73,11 +73,6 @@ void bufferDelete(struct Buffer *buf) {
 
 wchar_t *bufferDest(struct Buffer *buf, size_t len) {
 	if (buf->len + len > buf->cap) {
-		if (!buf->len) {
-			struct Block *empty = buf->block;
-			buf->block = buf->block->prev;
-			free(empty);
-		}
 		while (len > buf->cap) buf->cap *= 2;
 		buf->block = blockAlloc(buf->block, buf->cap);
 		buf->len = 0;
@@ -89,6 +84,12 @@ wchar_t *bufferDest(struct Buffer *buf, size_t len) {
 	return ptr;
 }
 
+void bufferTruncate(struct Buffer *buf, size_t len) {
+	if (len > buf->slice.len) return;
+	buf->len -= buf->slice.len - len;
+	buf->slice.len = len;
+}
+
 #ifdef TEST
 #include <assert.h>
 
@@ -159,6 +160,8 @@ int main() {
 	dest[4] = L'E';
 	dest[5] = L'F';
 	assert(!wcsncmp(L"ABCDEF", buf.slice.ptr, buf.slice.len));
+	bufferTruncate(&buf, 4);
+	assert(!wcsncmp(L"ABCD", buf.slice.ptr, buf.slice.len));
 	bufferFree(&buf);
 }
 
diff --git a/bin/edi/edi.h b/bin/edi/edi.h
index 62214e5d..fbfab40f 100644
--- a/bin/edi/edi.h
+++ b/bin/edi/edi.h
@@ -46,6 +46,7 @@ void bufferInsert(struct Buffer *buf);
 void bufferAppend(struct Buffer *buf, wchar_t ch);
 void bufferDelete(struct Buffer *buf);
 wchar_t *bufferDest(struct Buffer *buf, size_t len);
+void bufferTruncate(struct Buffer *buf, size_t len);
 
 static const struct Table {
 	size_t cap, len;
diff --git a/bin/edi/file.c b/bin/edi/file.c
index bfab9293..834730b1 100644
--- a/bin/edi/file.c
+++ b/bin/edi/file.c
@@ -25,14 +25,15 @@
 #include "edi.h"
 
 enum {
-	BufCap = 8192,
+	BufferCap = 8192,
+	TableCap = 2,
 	LogCap = 8,
 };
 
 struct File fileAlloc(char *path) {
 	struct File file = {
 		.path = path,
-		.buf = bufferAlloc(BufCap),
+		.buf = bufferAlloc(BufferCap),
 		.log = logAlloc(LogCap),
 	};
 	if (!path) logPush(&file.log, TableEmpty);
@@ -45,7 +46,7 @@ void fileFree(struct File *file) {
 	free(file->path);
 }
 
-static const mbstate_t MBStateInit;
+static const mbstate_t StateInit;
 
 // TODO: Error handling.
 void fileRead(struct File *file) {
@@ -59,22 +60,19 @@ void fileRead(struct File *file) {
 		return;
 	}
 
-	struct Table table = tableAlloc(1);
-
-	char buf[BufCap];
-	mbstate_t mbState = MBStateInit;
+	struct Table table = tableAlloc(TableCap);
+	char buf[BufferCap];
+	mbstate_t state = StateInit;
 	while (!feof(stream)) {
 		size_t mbsLen = fread(buf, 1, sizeof(buf), stream);
 		if (ferror(stream)) err(EX_IOERR, "%s", file->path);
 
 		const char *mbs = buf;
-		mbstate_t mbLenState = mbState;
-		size_t wcsLen = mbsnrtowcs(NULL, &mbs, mbsLen, 0, &mbLenState);
+		wchar_t *wcs = bufferDest(&file->buf, mbsLen);
+		size_t wcsLen = mbsnrtowcs(wcs, &mbs, mbsLen, mbsLen, &state);
 		if (wcsLen == (size_t)-1) err(EX_DATAERR, "%s", file->path);
 
-		wchar_t *wcs = bufferDest(&file->buf, wcsLen);
-		assert(wcsLen == mbsnrtowcs(wcs, &mbs, mbsLen, wcsLen, &mbState));
-
+		bufferTruncate(&file->buf, wcsLen);
 		tablePush(&table, file->buf.slice);
 	}
 	logPush(&file->log, table);
diff --git a/bin/edi/iter.c b/bin/edi/iter.c
index a4c97b71..cb34fc2d 100644
--- a/bin/edi/iter.c
+++ b/bin/edi/iter.c
@@ -79,6 +79,7 @@ int main() {
 	assert(L'B' == iter(&table, 1).ch);
 	assert(L'C' == iter(&table, 2).ch);
 	assert(L'D' == iter(&table, 3).ch);
+	assert(WEOF == iter(&table, 4).ch);
 
 	assert(L'B' == iterNext(iter(&table, 0)).ch);
 	assert(L'C' == iterNext(iter(&table, 1)).ch);
-- 
cgit 1.4.1