From 77b7eeb5f4f86b99c38144a285eba471405a3f6f Mon Sep 17 00:00:00 2001 From: June McEnroe Date: Wed, 18 Dec 2019 21:30:12 +0000 Subject: Bail from blame if blob is binary This avoids piping binary blobs through the source-filter. --- www/git.causal.agency/cgit/ui-blame.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'www') diff --git a/www/git.causal.agency/cgit/ui-blame.c b/www/git.causal.agency/cgit/ui-blame.c index f28eea0c..08832cd0 100644 --- a/www/git.causal.agency/cgit/ui-blame.c +++ b/www/git.causal.agency/cgit/ui-blame.c @@ -151,6 +151,10 @@ static void print_object(const struct object_id *oid, const char *path, cgit_tree_link("tree", NULL, NULL, ctx.qry.head, rev, path); html(")\n"); + if (buffer_is_binary(buf, size)) { + html("
blob is binary.
"); + goto cleanup; + } if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) { htmlf("
blob size (%ldKB)" " exceeds display size limit (%dKB).
", -- cgit 1.4.1