From 8402acf0fe1451b8508d4d81a2fae8e7927d0720 Mon Sep 17 00:00:00 2001 From: June McEnroe Date: Tue, 8 Aug 2017 20:44:22 -0400 Subject: Completely retry if a send fails during a broadcast This fixes a bug where the saved next client to iterate through would also get removed. This can result in messages being sent multiple times to a client, but that will have no negative effect. --- server.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'server.c') diff --git a/server.c b/server.c index 64e4e18..2fcdff7 100755 --- a/server.c +++ b/server.c @@ -123,16 +123,15 @@ static bool clientSend(const struct Client *client, const struct ServerMessage * } static void clientCast(const struct Client *origin, const struct ServerMessage *msg) { +retry: for (struct Client *client = clientHead; client; client = client->next) { if (client == origin) continue; if (client->tileX != origin->tileX) continue; if (client->tileY != origin->tileY) continue; if (!clientSend(client, msg)) { - struct Client *dead = client; - client = client->next; - clientRemove(dead); - if (!client) break; + clientRemove(client); + goto retry; } } } -- cgit 1.4.1