summary refs log tree commit diff homepage
Commit message (Expand)AuthorAge
...
* Day 3, part 2June McEnroe2020-11-22
* Day 3, clean upJune McEnroe2020-11-22
* Day 3June McEnroe2020-11-22
* Day 2, part 2June McEnroe2020-11-22
* Day 2June McEnroe2020-11-22
* Day 1, part 2June McEnroe2020-11-22
* Day 1June McEnroe2020-11-22
* Move to 2016 directoryJune McEnroe2020-11-22
* License ISCJune McEnroe2020-11-22
* Day 25June McEnroe2020-11-22
* Day 23 part 2June McEnroe2020-11-22
* Day 23June McEnroe2020-11-22
* Day 21 part 2June McEnroe2020-11-22
* FuckJune McEnroe2020-11-22
* Why doesn't day 21 work?June McEnroe2020-11-22
* Rewrite day 19 with VecDequeJune McEnroe2020-11-22
* Fix day 20 part 2 testJune McEnroe2020-11-22
* Day 20 part 2June McEnroe2020-11-22
* Day 20June McEnroe2020-11-22
* Day 19June McEnroe2020-11-22
* Fuck day 11 part 2June McEnroe2020-11-22
* Fuck day 11June McEnroe2020-11-22
* Day 17 part 2June McEnroe2020-11-22
* Day 17June McEnroe2020-11-22
* Day 18 part 2June McEnroe2020-11-22
* Day 18June McEnroe2020-11-22
* Day 16 part 2June McEnroe2020-11-22
* Day 16June McEnroe2020-11-22
* Day 15 part 2June McEnroe2020-11-22
* Day 15June McEnroe2020-11-22
* Day 14 part 2June McEnroe2020-11-22
* Day 14June McEnroe2020-11-22
* Day 13 part 2June McEnroe2020-11-22
* Day 13June McEnroe2020-11-22
* Day 12 part 2June McEnroe2020-11-22
* Day 12June McEnroe2020-11-22
* Day 10 part 2June McEnroe2020-11-22
* Day 10June McEnroe2020-11-22
* Day 9 part 2June McEnroe2020-11-22
* Refactor day 9June McEnroe2020-11-22
* Day 9June McEnroe2020-11-22
* Day 8 parts 1 and 2June McEnroe2020-11-22
* Day 7 part 2June McEnroe2020-11-22
* Refactor day 7June McEnroe2020-11-22
* Day 7June McEnroe2020-11-22
* Day 6 part 2June McEnroe2020-11-22
* Day 6, less gross?June McEnroe2020-11-22
* Day 6 (gross though)June McEnroe2020-11-22
* Day 5 part 2June McEnroe2020-11-22
* Day 5June McEnroe2020-11-22
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-11-10 10:13:23 +0000
o convert the commit buffer to a slab, removing the "buffer" field from "struct commit". All sites that access "commit->buffer" have been changed to use the new functions provided for this purpose. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-07-28parsing.c: make commit buffer constJohn Keeping This will be required in order to incorporate the changes to commit buffer handling in Git 2.0.2. Signed-off-by: John Keeping <john@keeping.me.uk> 2014-06-30Bump version.Jason A. Donenfeld 2014-06-29remove debug fprinf() calls that sneaked in with commit 79c985Christian Hesse 2014-06-28git: update to 2.0.1Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse