about summary refs log tree commit diff
diff options
context:
space:
mode:
authorChristian Hesse <mail@eworm.de>2018-08-28 18:14:32 +0200
committerChristian Hesse <mail@eworm.de>2018-09-11 08:47:12 +0200
commit60a930044d57faae4fcb84cba9d85310b0c767a7 (patch)
treee4ac6976f48f227d04982ecd7a17bdab74fb0db2
parentparsing: ban strncpy() (diff)
downloadcgit-pink-60a930044d57faae4fcb84cba9d85310b0c767a7.tar.gz
cgit-pink-60a930044d57faae4fcb84cba9d85310b0c767a7.zip
parsing: ban sprintf()
Git upstream bans sprintf() with commit:

  banned.h: mark sprintf() as banned
  cc8fdaee1eeaf05d8dd55ff11f111b815f673c58

Signed-off-by: Christian Hesse <mail@eworm.de>
Diffstat (limited to '')
-rw-r--r--parsing.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/parsing.c b/parsing.c
index e224564..9e73e70 100644
--- a/parsing.c
+++ b/parsing.c
@@ -77,7 +77,7 @@ static void parse_user(const char *t, char **name, char **email, unsigned long *
 
 		email_len = ident.mail_end - ident.mail_begin;
 		*email = xmalloc(strlen("<") + email_len + strlen(">") + 1);
-		sprintf(*email, "<%.*s>", email_len, ident.mail_begin);
+		xsnprintf(*email, email_len + 3, "<%.*s>", email_len, ident.mail_begin);
 
 		if (ident.date_begin)
 			*date = strtoul(ident.date_begin, NULL, 10);