diff options
| author | Lars Hjemli <hjemli@gmail.com> | 2007-10-27 13:50:18 +0200 |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2007-10-27 13:55:12 +0200 |
| commit | c61360fea0357672d2ab84a2c5a41ae1569f5d8a (patch) | |
| tree | c0d55917537b1cbc8237ee63e3a1252abbdded40 | |
| parent | Skip unknown header fields when parsing tags and commits (diff) | |
| download | cgit-pink-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.tar.gz cgit-pink-c61360fea0357672d2ab84a2c5a41ae1569f5d8a.zip | |
cgit_parse_commit(): Add missing call to xstrdup()
It's rather silly to point into random memory-locations. Also, remove a call to strdup() used on a literal char *. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | parsing.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/parsing.c b/parsing.c index ddbafd5..30e7648 100644 --- a/parsing.c +++ b/parsing.c @@ -242,14 +242,14 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) t = strchr(p, '\n'); if (t) { if (*t == '\0') - ret->subject = strdup("** empty **"); + ret->subject = "** empty **"; else ret->subject = substr(p, t); p = t + 1; while (*p == '\n') p = strchr(p, '\n') + 1; - ret->msg = p; + ret->msg = xstrdup(p); } else ret->subject = substr(p, p+strlen(p)); |