diff options
| author | Christian Hesse <mail@eworm.de> | 2015-10-09 13:15:45 +0200 |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2015-10-09 13:59:24 +0200 |
| commit | fa5810ed8e66c4b217b8e02d2682e0fdba7f102b (patch) | |
| tree | b39ae5cf1e824c5b57066d9d977da8fc90475f86 | |
| parent | ui-tree: fix resource leak: free before return (diff) | |
| download | cgit-pink-fa5810ed8e66c4b217b8e02d2682e0fdba7f102b.tar.gz cgit-pink-fa5810ed8e66c4b217b8e02d2682e0fdba7f102b.zip | |
ui-ssdiff: fix resource leak: free allocation from cgit_fileurl
Coverity-id: 13929 Signed-off-by: Christian Hesse <mail@eworm.de>
Diffstat (limited to '')
| -rw-r--r-- | ui-ssdiff.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/ui-ssdiff.c b/ui-ssdiff.c index 2146c71..d183d40 100644 --- a/ui-ssdiff.c +++ b/ui-ssdiff.c @@ -230,11 +230,13 @@ static void print_ssdiff_line(char *class, struct diff_filespec *old_file = cgit_get_current_old_file(); char *lineno_str = fmt("n%d", old_line_no); char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str); + char *fileurl = cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str); html("<td class='lineno'><a href='"); - html(cgit_fileurl(ctx.repo->url, "tree", old_file->path, id_str)); + html(fileurl); htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1); html("</td>"); htmlf("<td class='%s'>", class); + free(fileurl); } else if (old_line) htmlf("<td class='lineno'></td><td class='%s'>", class); else @@ -251,11 +253,13 @@ static void print_ssdiff_line(char *class, struct diff_filespec *new_file = cgit_get_current_new_file(); char *lineno_str = fmt("n%d", new_line_no); char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str); + char *fileurl = cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str); html("<td class='lineno'><a href='"); - html(cgit_fileurl(ctx.repo->url, "tree", new_file->path, id_str)); + html(fileurl); htmlf("' id='%s'>%s</a>", lineno_str, lineno_str + 1); html("</td>"); htmlf("<td class='%s'>", class); + free(fileurl); } else if (new_line) htmlf("<td class='lineno'></td><td class='%s'>", class); else |