about summary refs log tree commit diff
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-01-04 22:23:24 +0000
committerJune McEnroe <june@causal.agency>2022-02-13 11:55:35 -0500
commit2d4c893dbdfea6a5ccefa75017113d45b33f2c43 (patch)
tree81036c21a04b42d38c59274043fb22e84174bb10
parentImprove decoration display for browsers without CSS (diff)
downloadcgit-pink-2d4c893dbdfea6a5ccefa75017113d45b33f2c43.tar.gz
cgit-pink-2d4c893dbdfea6a5ccefa75017113d45b33f2c43.zip
Improve button spacing for browsers w/o CSS
For browsers on low-end machines running browsers without CSS
support, the default tree view displayed "logplain" when it
should be "log plain".  Stop relying on CSS and add a space
in between elements to improve accessibility.
-rw-r--r--cgit.css1
-rw-r--r--ui-repolist.c2
-rw-r--r--ui-tree.c12
3 files changed, 11 insertions, 4 deletions
diff --git a/cgit.css b/cgit.css
index b88db61..dac791b 100644
--- a/cgit.css
+++ b/cgit.css
@@ -576,7 +576,6 @@ div#cgit table.list td.reposection {
 
 div#cgit a.button {
 	font-size: 80%;
-	padding: 0em 0.5em;
 }
 
 div#cgit a.primary {
diff --git a/ui-repolist.c b/ui-repolist.c
index 529a203..591929b 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -353,8 +353,10 @@ void cgit_print_repolist(void)
 		if (ctx.cfg.enable_index_links) {
 			html("<td>");
 			cgit_summary_link("summary", NULL, "button", NULL);
+			html(" ");
 			cgit_log_link("log", NULL, "button", NULL, NULL, NULL,
 				      0, NULL, NULL, ctx.qry.showmsg, 0);
+			html(" ");
 			cgit_tree_link("tree", NULL, "button", NULL, NULL, NULL);
 			html("</td>");
 		}
diff --git a/ui-tree.c b/ui-tree.c
index 438b001..34e7e63 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -263,15 +263,21 @@ static int ls_item(const struct object_id *oid, struct strbuf *base,
 	cgit_log_link("log", NULL, "button", ctx.qry.head,
 		      walk_tree_ctx->curr_rev, fullpath.buf, 0, NULL, NULL,
 		      ctx.qry.showmsg, 0);
-	if (ctx.repo->max_stats)
+	if (ctx.repo->max_stats) {
+		html(" ");
 		cgit_stats_link("stats", NULL, "button", ctx.qry.head,
 				fullpath.buf);
-	if (!S_ISGITLINK(mode))
+	}
+	if (!S_ISGITLINK(mode)) {
+		html(" ");
 		cgit_plain_link("plain", NULL, "button", ctx.qry.head,
 				walk_tree_ctx->curr_rev, fullpath.buf);
-	if (!S_ISDIR(mode) && ctx.repo->enable_blame)
+	}
+	if (!S_ISDIR(mode) && ctx.repo->enable_blame) {
+		html(" ");
 		cgit_blame_link("blame", NULL, "button", ctx.qry.head,
 				walk_tree_ctx->curr_rev, fullpath.buf);
+	}
 	html("</td></tr>\n");
 
 cleanup: