about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLukasz Janyst <ljanyst@cern.ch>2011-03-05 14:10:55 +0100
committerLars Hjemli <hjemli@gmail.com>2011-03-05 14:13:06 +0100
commit7f3c6e0ce9b41142cf2707af100992acdce059df (patch)
tree119a1920c85adcc65017afc8d9d95ab3e2bafef4
parentMerge branch 'stable' (diff)
downloadcgit-pink-7f3c6e0ce9b41142cf2707af100992acdce059df.tar.gz
cgit-pink-7f3c6e0ce9b41142cf2707af100992acdce059df.zip
ui-diff.c: avoid html injection
When path-filtering was used in commit-view, the path filter was
included without proper html escaping. This patch closes the hole.

Signed-off-by: Lukasz Janyst <ljanyst@cern.ch>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--ui-diff.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/ui-diff.c b/ui-diff.c
index a53425d..a7bc667 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -172,8 +172,11 @@ void cgit_print_diffstat(const unsigned char *old_sha1,
 	html("<div class='diffstat-header'>");
 	cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1,
 		       ctx.qry.sha2, NULL, 0);
-	if (prefix)
-		htmlf(" (limited to '%s')", prefix);
+	if (prefix) {
+		html(" (limited to '");
+		html_txt(prefix);
+		html("')");
+	}
 	html(" (");
 	ctx.qry.context = (save_context > 0 ? save_context : 3) << 1;
 	cgit_self_link("more", NULL, NULL, &ctx);