about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2016-08-13 11:51:58 +0100
committerJohn Keeping <john@keeping.me.uk>2016-10-01 11:46:55 +0100
commitd9dff37691633aa44524ecae216c103ea497e940 (patch)
tree45ade38d5de7eb448ce05b4753429d446a8bc592
parenttree: allow skipping through single-child trees (diff)
downloadcgit-pink-d9dff37691633aa44524ecae216c103ea497e940.tar.gz
cgit-pink-d9dff37691633aa44524ecae216c103ea497e940.zip
shared: remove return value from cgit_free_commitinfo()
This return value is never used and the function always returns NULL.

Signed-off-by: John Keeping <john@keeping.me.uk>
-rw-r--r--cgit.h2
-rw-r--r--shared.c3
2 files changed, 2 insertions, 3 deletions
diff --git a/cgit.h b/cgit.h
index f34395c..7df0e3a 100644
--- a/cgit.h
+++ b/cgit.h
@@ -343,7 +343,7 @@ extern void cgit_free_reflist_inner(struct reflist *list);
 extern int cgit_refs_cb(const char *refname, const struct object_id *oid,
 			int flags, void *cb_data);
 
-extern void *cgit_free_commitinfo(struct commitinfo *info);
+extern void cgit_free_commitinfo(struct commitinfo *info);
 
 void cgit_diff_tree_cb(struct diff_queue_struct *q,
 		       struct diff_options *options, void *data);
diff --git a/shared.c b/shared.c
index a48eea6..3ada875 100644
--- a/shared.c
+++ b/shared.c
@@ -95,7 +95,7 @@ struct cgit_repo *cgit_get_repoinfo(const char *url)
 	return NULL;
 }
 
-void *cgit_free_commitinfo(struct commitinfo *info)
+void cgit_free_commitinfo(struct commitinfo *info)
 {
 	free(info->author);
 	free(info->author_email);
@@ -105,7 +105,6 @@ void *cgit_free_commitinfo(struct commitinfo *info)
 	free(info->msg);
 	free(info->msg_encoding);
 	free(info);
-	return NULL;
 }
 
 char *trim_end(const char *str, char c)