about summary refs log tree commit diff
diff options
context:
space:
mode:
authorLars Hjemli <hjemli@gmail.com>2006-12-16 14:46:05 +0100
committerLars Hjemli <hjemli@gmail.com>2006-12-16 14:46:05 +0100
commitfa82b03e05366e3c6ca1b74c8c83d6e00e0ef1e6 (patch)
tree5831136ea360e9680fe2c77c4e6f2805b2d0f0c9
parentShow emails and timestamps in ui-commit.c (diff)
downloadcgit-pink-fa82b03e05366e3c6ca1b74c8c83d6e00e0ef1e6.tar.gz
cgit-pink-fa82b03e05366e3c6ca1b74c8c83d6e00e0ef1e6.zip
Simplify ui-commit.c
Replace the call to lookup_commit() with a call to lookup_commit_reference,
since it handles reading and parsing of the commit object internally.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r--ui-commit.c17
1 files changed, 1 insertions, 16 deletions
diff --git a/ui-commit.c b/ui-commit.c
index e9de411..b441e14 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -13,9 +13,6 @@ void cgit_print_commit(const char *hex)
 	struct commit *commit;
 	struct commitinfo *info;
 	struct commit_list *p;
-	unsigned long size;
-	char type[20];
-	char *buf;
 
 	unsigned char sha1[20];
 
@@ -24,24 +21,12 @@ void cgit_print_commit(const char *hex)
 		return;
 	}
 
-	buf = read_sha1_file(sha1, type, &size);
-	if (!buf) {
-		cgit_print_error(fmt("Bad object reference: %s", hex));
-		return;
-	}
-
-	commit = lookup_commit(sha1);
+	commit = lookup_commit_reference(sha1);
 	if (!commit) {
 		cgit_print_error(fmt("Bad commit reference: %s", hex));
 		return;
 	}
 
-	commit->buffer = buf;
-	if (parse_commit_buffer(commit, buf, size)) {
-		cgit_print_error(fmt("Malformed commit buffer: %s", hex));
-		return;
-	}
-
 	info = cgit_parse_commit(commit);
 
 	html("<table class='commit-info'>\n");