about summary refs log tree commit diff
diff options
context:
space:
mode:
authorChristian Hesse <mail@eworm.de>2015-10-10 16:56:27 +0200
committerJason A. Donenfeld <Jason@zx2c4.com>2015-10-10 21:40:26 +0200
commited5dccbeaab5c8b30e1c2fe8890fa098537a2621 (patch)
treee3a672c17f5589a417bf9318f6b31a598c5aa8f8
parentui-atom: fix resource leak: free before return (diff)
downloadcgit-pink-ed5dccbeaab5c8b30e1c2fe8890fa098537a2621.tar.gz
cgit-pink-ed5dccbeaab5c8b30e1c2fe8890fa098537a2621.zip
ui-atom: fix resource leak: free allocation from cgit_pageurl
Coverity-id: 13945
Signed-off-by: Christian Hesse <mail@eworm.de>
-rw-r--r--ui-atom.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/ui-atom.c b/ui-atom.c
index fab4b0f..e186299 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -53,14 +53,17 @@ static void add_entry(struct commit *commit, const char *host)
 	cgit_print_date(info->author_date, FMT_ATOMDATE, 0);
 	html("</published>\n");
 	if (host) {
+		char *pageurl;
 		html("<link rel='alternate' type='text/html' href='");
 		html(cgit_httpscheme());
 		html_attr(host);
-		html_attr(cgit_pageurl(ctx.repo->url, "commit", NULL));
+		pageurl = cgit_pageurl(ctx.repo->url, "commit", NULL);
+		html_attr(pageurl);
 		if (ctx.cfg.virtual_root)
 			delim = '?';
 		htmlf("%cid=%s", delim, hex);
 		html("'/>\n");
+		free(pageurl);
 	}
 	htmlf("<id>%s</id>\n", hex);
 	html("<content type='text'>\n");