about summary refs log tree commit diff
diff options
context:
space:
mode:
authorChristian Hesse <mail@eworm.de>2018-08-28 18:22:26 +0200
committerChristian Hesse <mail@eworm.de>2018-09-11 08:47:12 +0200
commit0899eb644fab415e9a3b304f53da9da50aaf91aa (patch)
tree3660c115fff77d75e07d92b39bb54c1440ee5b42
parentui-shared: ban strcat() (diff)
downloadcgit-pink-0899eb644fab415e9a3b304f53da9da50aaf91aa.tar.gz
cgit-pink-0899eb644fab415e9a3b304f53da9da50aaf91aa.zip
ui-ssdiff: ban strncpy()
Git upstream bans strncpy() with commit:

  banned.h: mark strncpy() as banned
  e488b7aba743d23b830d239dcc33d9ca0745a9ad

Signed-off-by: Christian Hesse <mail@eworm.de>
-rw-r--r--ui-ssdiff.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 68c2044..a3dd059 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -103,8 +103,7 @@ static int line_from_hunk(char *line, char type)
 		return 0;
 	len = buf2 - buf1;
 	buf2 = xmalloc(len + 1);
-	strncpy(buf2, buf1, len);
-	buf2[len] = '\0';
+	strlcpy(buf2, buf1, len + 1);
 	res = atoi(buf2);
 	free(buf2);
 	return res;