diff options
| author | John Keeping <john@keeping.me.uk> | 2016-08-07 15:54:14 +0100 |
|---|---|---|
| committer | John Keeping <john@keeping.me.uk> | 2016-10-01 11:43:33 +0100 |
| commit | 35df710a1fa21b62c5328e2c98f29a68a0312a25 (patch) | |
| tree | db984e301d72179483d6173138f2323b02b98967 /README | |
| parent | git: update to v2.10.0 (diff) | |
| download | cgit-pink-35df710a1fa21b62c5328e2c98f29a68a0312a25.tar.gz cgit-pink-35df710a1fa21b62c5328e2c98f29a68a0312a25.zip | |
configfile: fix EOF handling
Currently we can end up passing EOF to isspace(), which is in fact libgit's sane_isspace which does: ((sane_ctype[(unsigned char)(x)] & (GIT_SPACE)) != 0) It is very unlikely that EOF cast to "unsigned char" will end up in a character that has the GIT_SPACE bit set, but the standard only requires that EOF be a negative integer, so it could access any value in the sane_ctype array. If it does end up returning true for isspace() then this loop will never terminate, so handle EOF as a special value in the same way as the other loops in this function. Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'README')
0 files changed, 0 insertions, 0 deletions