diff options
| author | Lars Hjemli <hjemli@gmail.com> | 2006-12-11 22:53:50 +0100 |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2006-12-11 22:53:50 +0100 |
| commit | fbaf1171b4e343929dd43ecac7cd9d1c692b84ec (patch) | |
| tree | 40b7007b2e1e85f2e91e052b33555df2e9fb5e14 /cache.c | |
| parent | Move global variables + callback functions into shared.c (diff) | |
| download | cgit-pink-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.tar.gz cgit-pink-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.zip | |
Don't truncate valid cachefiles
An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles
in the following situation:
1) process A notices a missing/expired cachefile
2) process B gets scheduled, locks, fills and unlocks the cachefile
3) process A gets scheduled, locks the cachefile, notices that the cachefile
now exist/is not expired anymore, and continues to overwrite it with an
empty lockfile.
Thanks to Linus for noticing (again).
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (limited to 'cache.c')
| -rw-r--r-- | cache.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/cache.c b/cache.c index 2e1ef8c..b947a34 100644 --- a/cache.c +++ b/cache.c @@ -99,6 +99,11 @@ int cache_unlock(struct cacheitem *item) return (rename(fmt("%s.lock", item->name), item->name) == 0); } +int cache_cancel_lock(struct cacheitem *item) +{ + return (unlink(fmt("%s.lock", item->name)) == 0); +} + int cache_expired(struct cacheitem *item) { if (item->ttl < 0) |