diff options
| author | Mark Lodato <lodatom@gmail.com> | 2010-09-04 11:30:18 -0400 |
|---|---|---|
| committer | Mark Lodato <lodatom@gmail.com> | 2010-09-04 11:35:38 -0400 |
| commit | e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2 (patch) | |
| tree | 2ade0bb45e15ad5466ca4d3433201477f0c9214e /cgit.c | |
| parent | use __attribute__ to catch printf format mistakes (diff) | |
| download | cgit-pink-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.tar.gz cgit-pink-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.zip | |
fix errors in printf-style format strings
There were many places where the arguments to a printf-like function did not match the format string. Mostly, these were a missing 'l' flag, but there were three exceptions: - In ui-stats.c, a size_t argument must be printed. C99 has the "%zu" flag for this purpose, but not all compilers support this. Therefore, we mimic what git does - use a NO_C99_FORMAT Makefile variable. - In ui-stats.c, cgit_print_error() was called with a pointer instead of a character. - In ui-log.c, the "columns" argument was never used. Signed-off-by: Mark Lodato <lodatom@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | cgit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cgit.c b/cgit.c index d6146e2..3b3f8d9 100644 --- a/cgit.c +++ b/cgit.c @@ -610,7 +610,7 @@ static void process_cached_repolist(const char *path) hash = hash_str(path); if (ctx.cfg.project_list) hash += hash_str(ctx.cfg.project_list); - cached_rc = xstrdup(fmt("%s/rc-%8x", ctx.cfg.cache_root, hash)); + cached_rc = xstrdup(fmt("%s/rc-%8lx", ctx.cfg.cache_root, hash)); if (stat(cached_rc, &st)) { /* Nothing is cached, we need to scan without forking. And |