about summary refs log tree commit diff
path: root/tests/valgrind/bin/cgit
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2016-08-07 15:54:14 +0100
committerJohn Keeping <john@keeping.me.uk>2016-10-01 11:43:33 +0100
commit35df710a1fa21b62c5328e2c98f29a68a0312a25 (patch)
treedb984e301d72179483d6173138f2323b02b98967 /tests/valgrind/bin/cgit
parentgit: update to v2.10.0 (diff)
downloadcgit-pink-35df710a1fa21b62c5328e2c98f29a68a0312a25.tar.gz
cgit-pink-35df710a1fa21b62c5328e2c98f29a68a0312a25.zip
configfile: fix EOF handling
Currently we can end up passing EOF to isspace(), which is in fact
libgit's sane_isspace which does:

	((sane_ctype[(unsigned char)(x)] & (GIT_SPACE)) != 0)

It is very unlikely that EOF cast to "unsigned char" will end up in a
character that has the GIT_SPACE bit set, but the standard only requires
that EOF be a negative integer, so it could access any value in the
sane_ctype array.

If it does end up returning true for isspace() then this loop will never
terminate, so handle EOF as a special value in the same way as the other
loops in this function.

Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'tests/valgrind/bin/cgit')
0 files changed, 0 insertions, 0 deletions
24-07-04/lens?id=33dc5229a56defdf616b72c5e32dab42beb11918&follow=1'>Add the end of the Harman Phoenix rollJune McEnroe 2024-07-08Add photos from July 3, the hikeJune McEnroe 2024-07-07Add photos from July 1June McEnroe 2024-07-07Add photos from June 25-30June McEnroe 2024-06-30Add photos from June 22 (and the few days after that)June McEnroe 2024-06-30Accommodate lower-case .jpg filesJune McEnroe 2024-06-23Add another BACKXWASH showJune McEnroe It was good! 2024-06-16Update bioJune McEnroe 2024-06-15Add photo descriptions from June 12June McEnroe 2024-06-10Add first roll of film from June 8June McEnroe 2024-06-10Cope with not having an EXIF infoJune McEnroe 2024-06-10Resize using target pixel counts for consistencyJune McEnroe This will resize film scans to about the same size as for the digital photos. 2024-06-10Add The Girl Who Was Convinced...June McEnroe Not much there. The illustrations are very nice though. 2024-06-09Add photos from May 31June McEnroe 2024-06-09Use monospace on photo pagesJune McEnroe 2024-06-09Put lens and (future) film at the tops of photo pagesJune McEnroe 2024-05-22Remove use of sysexits.hJune McEnroe 2024-05-22Add photo descriptions from 05-03 and 05-06June McEnroe 2024-05-21Fix = precedence in whenJune McEnroe