about summary refs log tree commit diff
path: root/tests/valgrind
diff options
context:
space:
mode:
authorJohn Keeping <john@keeping.me.uk>2016-01-16 11:03:05 +0000
committerJason A. Donenfeld <Jason@zx2c4.com>2016-01-17 17:05:00 +0100
commitbaa5ad1f80f56d3c0b0095bfb468fab28c9b4982 (patch)
tree5e23e5f9ebf7bbccbf431e056588442f1a8b924c /tests/valgrind
parentBump version (diff)
downloadcgit-pink-baa5ad1f80f56d3c0b0095bfb468fab28c9b4982.tar.gz
cgit-pink-baa5ad1f80f56d3c0b0095bfb468fab28c9b4982.zip
ui-log: handle parse_commit() errors
If parse_commit() fails, none of the fields in the commit structure will
have been populated so we will dereference NULL when accessing
item->tree.

There isn't much we can do about the error at this point, but if we
return true then we'll try parsing the commit again from print_commit()
and we can report an error to the user at that point.

Coverity-id: 13801
Signed-off-by: John Keeping <john@keeping.me.uk>
Diffstat (limited to 'tests/valgrind')
0 files changed, 0 insertions, 0 deletions
f='/pounce/commit/state.c?h=1.0&id=e2be3c85131896e203f7ba16d883bc61bfa09064&follow=1'>Synchronize state after client registrationJune McEnroe 2019-10-23Send to server if client has no needsJune McEnroe 2019-10-23Implement some amount of client connectionJune McEnroe 2019-10-23Set clients non-blockingJune McEnroe 2019-10-23Clean up state.c and factor out parsingJune McEnroe 2019-10-23Respond to pingsJune McEnroe 2019-10-23Add verbose flagJune McEnroe 2019-10-23Set NOSIGPIPE on server connectionJune McEnroe 2019-10-23Set an initial loop capJune McEnroe 2019-10-23Fix rest parsingJune McEnroe 2019-10-23Add dynamic poll listJune McEnroe 2019-10-23Don't assume commands have targets and handle ERRORJune McEnroe 2019-10-23Clean up state somewhatJune McEnroe 2019-10-23Actually send the buffer...June McEnroe 2019-10-23Add stateJune McEnroe