diff options
author | Mark Lodato <lodatom@gmail.com> | 2010-09-04 11:30:18 -0400 |
---|---|---|
committer | Mark Lodato <lodatom@gmail.com> | 2010-09-04 11:35:38 -0400 |
commit | e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2 (patch) | |
tree | 2ade0bb45e15ad5466ca4d3433201477f0c9214e /ui-diff.c | |
parent | use __attribute__ to catch printf format mistakes (diff) | |
download | cgit-pink-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.tar.gz cgit-pink-e4ddc8f72b5a7d8c55a6c2042c7b7f945ba4b1a2.zip |
fix errors in printf-style format strings
There were many places where the arguments to a printf-like function did not match the format string. Mostly, these were a missing 'l' flag, but there were three exceptions: - In ui-stats.c, a size_t argument must be printed. C99 has the "%zu" flag for this purpose, but not all compilers support this. Therefore, we mimic what git does - use a NO_C99_FORMAT Makefile variable. - In ui-stats.c, cgit_print_error() was called with a pointer instead of a character. - In ui-log.c, the "columns" argument was never used. Signed-off-by: Mark Lodato <lodatom@gmail.com>
Diffstat (limited to '')
-rw-r--r-- | ui-diff.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-diff.c b/ui-diff.c index 0dcabe9..7ff7e46 100644 --- a/ui-diff.c +++ b/ui-diff.c @@ -92,7 +92,7 @@ static void print_fileinfo(struct fileinfo *info) info->old_path); html("</td><td class='right'>"); if (info->binary) { - htmlf("bin</td><td class='graph'>%d -> %d bytes", + htmlf("bin</td><td class='graph'>%ld -> %ld bytes", info->old_size, info->new_size); return; } |