about summary refs log tree commit diff
path: root/ui-log.c
diff options
context:
space:
mode:
authorPeter Wu <lekensteyn@gmail.com>2013-10-03 12:17:23 +0200
committerJason A. Donenfeld <Jason@zx2c4.com>2014-01-08 14:59:38 +0100
commit4468ec1b15becf3838d8cf38440c527c487565a4 (patch)
tree4c9220561ab256dc012e17146f6d0546637e6c69 /ui-log.c
parentplain: don't append charset for binary MIME types (diff)
downloadcgit-pink-4468ec1b15becf3838d8cf38440c527c487565a4.tar.gz
cgit-pink-4468ec1b15becf3838d8cf38440c527c487565a4.zip
Reduce line number bloat, fix hover effect
Currently line numbers look like (for blob view and sdiff respectively):

    <a class='no' id='n68' name='n68' href='#n68'>68</a>
    <td class='lineno'><a class='no' href='...#n1' id='n1' name='n1'>1</a></td>

name=".." is unnecessary if the id attribute is set (this even applies
to IE6), so drop it. (aside, in HTML5, the name attribute is gone.)

The line number links can be selected through their parent classes, no
need for another class "no", so drop it too.

For a file with 2000 lines, this yields a saving of 40% (29% gzipped).

While at it, fix the hover effect of line numbers: now the line number
get a black background as was intended.

Signed-off-by: Peter Wu <lekensteyn@gmail.com>
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions
ommit/bin/hi.c?id=120118ddfb1b487585f4b9ae399b6c5c32ae7c48&follow=1'>Don't match DQ string inside SQ stringJune McEnroe 2019-02-10Skip only one character if a match fails due to parentJune McEnroe Really it should skip forward until the parent changes, but this is simpler. 2019-02-10Remove pattend from hiJune McEnroe 2019-02-10Replace uses of pattend with newline patternsJune McEnroe 2019-02-10Add hi debug outputJune McEnroe 2019-02-10Actually do HTML &quot; escapingJune McEnroe 2019-02-10Set git commit.verboseJune McEnroe 2019-02-10Add back missing static keywordJune McEnroe