diff options
author | Peter Wu <lekensteyn@gmail.com> | 2013-10-03 12:17:23 +0200 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2014-01-08 14:59:38 +0100 |
commit | 4468ec1b15becf3838d8cf38440c527c487565a4 (patch) | |
tree | 4c9220561ab256dc012e17146f6d0546637e6c69 /ui-tree.c | |
parent | plain: don't append charset for binary MIME types (diff) | |
download | cgit-pink-4468ec1b15becf3838d8cf38440c527c487565a4.tar.gz cgit-pink-4468ec1b15becf3838d8cf38440c527c487565a4.zip |
Reduce line number bloat, fix hover effect
Currently line numbers look like (for blob view and sdiff respectively): <a class='no' id='n68' name='n68' href='#n68'>68</a> <td class='lineno'><a class='no' href='...#n1' id='n1' name='n1'>1</a></td> name=".." is unnecessary if the id attribute is set (this even applies to IE6), so drop it. (aside, in HTML5, the name attribute is gone.) The line number links can be selected through their parent classes, no need for another class "no", so drop it too. For a file with 2000 lines, this yields a saving of 40% (29% gzipped). While at it, fix the hover effect of line numbers: now the line number get a black background as was intended. Signed-off-by: Peter Wu <lekensteyn@gmail.com> Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
Diffstat (limited to 'ui-tree.c')
-rw-r--r-- | ui-tree.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ui-tree.c b/ui-tree.c index aa5dee9..52b57b7 100644 --- a/ui-tree.c +++ b/ui-tree.c @@ -21,8 +21,7 @@ struct walk_tree_context { static void print_text_buffer(const char *name, char *buf, unsigned long size) { unsigned long lineno, idx; - const char *numberfmt = - "<a class='no' id='n%1$d' name='n%1$d' href='#n%1$d'>%1$d</a>\n"; + const char *numberfmt = "<a id='n%1$d' href='#n%1$d'>%1$d</a>\n"; html("<table summary='blob content' class='blob'>\n"); |