about summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* mime: rewrite detection functionJason A. Donenfeld2015-08-17
* ui-summary: send images plain for about pageChristian Hesse2015-08-17
* refactor get_mimetype_from_file() to get_mimetype_for_filename()Christian Hesse2015-08-17
* move get_mimetype_from_file() to sharedChristian Hesse2015-08-17
* cmd: fix command definitionJohn Keeping2015-08-14
* cmd: no need for pre function hook nowJason A. Donenfeld2015-08-14
* ui-shared: cache errors for "dynamic TTL"John Keeping2015-08-14
* cmd: remove "want_layout" fieldJohn Keeping2015-08-14
* tree: move layout into page functionJohn Keeping2015-08-14
* tag: move layout into page functionJohn Keeping2015-08-14
* summary: move layout into page functionJohn Keeping2015-08-14
* stats: move layout into page functionJohn Keeping2015-08-14
* refs: move layout to page functionJohn Keeping2015-08-14
* log: move layout into page functionJohn Keeping2015-08-14
* diff: move layout to page functionJohn Keeping2015-08-14
* commit: move layout into page functionJohn Keeping2015-08-14
* about: move layout into page functionsJohn Keeping2015-08-14
* ui-shared: add cgit_print_layout_{start,end}()John Keeping2015-08-14
* html: remove html_status()John Keeping2015-08-14
* snapshot: don't reimplement cgit_print_error_page()John Keeping2015-08-14
* snapshot: use cgit_print_error_page() for HTTP status codesJohn Keeping2015-08-14
* patch: use cgit_print_error_page() for HTTP status codesJohn Keeping2015-08-14
* blob: use cgit_print_error_page() to add HTTP headersJohn Keeping2015-08-14
* snapshot: use cgit_print_error_page() instead of html_status()John Keeping2015-08-14
* plain: use cgit_print_error_page() instead of html_status()John Keeping2015-08-14
* clone: use cgit_print_error_page() instead of html_status()John Keeping2015-08-14
* cgit: use cgit_print_error_page() where appropriateJohn Keeping2015-08-14
* ui-shared: add cgit_print_error_page() functionJohn Keeping2015-08-14
* ui-patch: make sure to send http headersChristian Hesse2015-08-14
* Makefile: make "git/config.mak.uname" inclusion optionalJohn Keeping2015-08-13
* ui-shared: show full date in tooltip if longer ago than max_relativeJohn Keeping2015-08-13
* ui-shared: use common function in print_rel_date()John Keeping2015-08-13
* ui-shared: extract date formatting to a functionJohn Keeping2015-08-13
* filter: don't use dlsym unnecessarilyJohn Keeping2015-08-13
* ui-tree: use "sane" isgraph()John Keeping2015-08-13
* cgit.h: move stdbool.h from ui-shared.hJohn Keeping2015-08-13
* cache.c: fix header orderJohn Keeping2015-08-13
* configfile.c: don't include system headers directlyJohn Keeping2015-08-13
* Remove redundant includesJohn Keeping2015-08-13
* Makefile: include Git's config.mak.unameJohn Keeping2015-08-13
* tests: allow shell to be overriddenJohn Keeping2015-08-13
* redirect: cleanlinessJason A. Donenfeld2015-08-13
* redirect: be more careful for different cgi setupsJason A. Donenfeld2015-08-13
* ui-log: fix double countingJohn Keeping2015-08-12
* log: allow users to follow a fileJohn Keeping2015-08-12
* shared: make cgit_diff_tree_cb publicJohn Keeping2015-08-12
* t0110: Chain together using &&Jason A. Donenfeld2015-08-12
* about: always ensure page has a trailing slashJason A. Donenfeld2015-08-12
* filters: apply HTML escapingLazaros Koromilas2015-08-12
* git: update to v2.5.0Christian Hesse2015-08-12
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-29 22:39:08 +0000
logheader'>2014-06-28ui-patch: Flush stdout after outputting dataJohn Keeping It looks like cached patches are truncated to the nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse