about summary refs log tree commit diff
Commit message (Expand)AuthorAge
* cgit_print_commit(): Free tmp variableLukas Fleischer2013-03-04
* cgit_print_tree(): Free curr_rev after usageLukas Fleischer2013-03-04
* find_default_branch(): Free refmatch after usageLukas Fleischer2013-03-04
* print_tag_downloads(): Free ref variableLukas Fleischer2013-03-04
* Free reflists after usageLukas Fleischer2013-03-04
* ui-shared.c: Remove unused function print_archive_ref()Lukas Fleischer2013-03-04
* ui-shared.c: Remove unused function cgit_currurl()Lukas Fleischer2013-03-04
* Mark several functions/variables staticLukas Fleischer2013-03-04
* t0107-snapshot: add tests for ZIP archivesJohn Keeping2013-03-04
* tests: make whitespace consistentJohn Keeping2013-03-04
* tests: "grep -e" is not portable to all platformsJohn Keeping2013-03-04
* Makefile: Disable gettext in the Git submoduleLukas Fleischer2013-03-04
* Makefile: improve dependency generationJamie Couture2013-03-04
* cgit.c: Remove parameter from guess_defbranch()Lukas Fleischer2013-03-04
* ui-tree.c: Use a context structure in walk_tree()Lukas Fleischer2013-03-04
* ui-tree.c: Drop the header variableLukas Fleischer2013-03-04
* ui-tree.c: Declare the state variable globallyLukas Fleischer2013-03-04
* ui-tree.c: Pass current revision to print_object()Lukas Fleischer2013-03-04
* ui-plain.c: Use a context structure in walk_tree()Lukas Fleischer2013-03-04
* ui-plain.c: Do not access match variable in print_*()Lukas Fleischer2013-03-04
* ui-blob.c: Use a context structure in walk_tree()Lukas Fleischer2013-03-04
* ui-snapshot.c: Fill argv[0] with dummy.Jason A. Donenfeld2013-03-04
* White space around control verbs.Jason A. Donenfeld2013-03-04
* Fix several whitespace errorsLukas Fleischer2013-03-04
* Update git to v1.7.12.4John Keeping2013-03-02
* Update git to v1.7.9.7John Keeping2013-03-02
* Update git to v1.7.8.6John Keeping2013-03-02
* Update git to v1.7.7.7John Keeping2013-03-02
* Update git to v1.7.6.5John Keeping2013-03-02
* Update git to v1.7.5.4John Keeping2013-03-02
* Print submodule revision next to submodule linkstfn2013-03-02
* Support unannotated tags in git-clone.Jason A. Donenfeld2013-02-01
* ssdiff: correctly manage tab expansionJulius Plenz2013-02-01
* Make "owner" column on index page configurableFlorian Pritz2013-02-01
* man: fix up default value duplicationJason A. Donenfeld2012-11-15
* CGIT-0.9.1Jason A. Donenfeld2012-11-15
* man: show mime type default valueJason A. Donenfeld2012-11-15
* ssdiff: point line links at exact blob by prepending "id="Julius Plenz2012-11-15
* Format git diff headers correctly when adding or removing files.Michael Halstead2012-11-15
* Makefile: get snapshots from githubFerry Huberts2012-11-04
* Makefile: remove tags fileJamie Couture2012-10-31
* ui-shared: use placeholder for empty commit subjectChristian Franke2012-10-28
* syntax-highlighting.sh: Fix command injection.Jason A. Donenfeld2012-10-27
* Fix man page typo.Jason A. Donenfeld2012-10-18
* Makefile: Support OpenBSD just like FreeBSDJason A. Donenfeld2012-10-17
* Makefile: support FreeBSD libiconv pathsJason A. Donenfeld2012-10-17
* tests: check for proper html entityJason A. Donenfeld2012-10-17
* ui-log: Add "commit-sort" option for controlling commit orderingTobias Bieniek2012-10-17
* ui-repolist: Add "section-sort" flag to control section sorting.Tobias Bieniek2012-10-17
* scan-tree: Unify gitweb.* and cgit.* settings into one config option.Jason A. Donenfeld2012-10-17
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-10-26 17:45:28 +0000
n the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu