about summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* ui-commit: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse2016-10-04
* ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse2016-10-04
* cgit: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse2016-10-04
* Makefile: remove extra spaceJason A. Donenfeld2016-10-01
* Simplify http_parse_querystring()Lukas Fleischer2016-10-01
* ui-tree: remove a fixed size bufferJohn Keeping2016-10-01
* ui-tag: clean up taginfoJohn Keeping2016-10-01
* shared: make cgit_free_taginfo() publicJohn Keeping2016-10-01
* shared: remove return value from cgit_free_commitinfo()John Keeping2016-10-01
* tree: allow skipping through single-child treesJohn Keeping2016-10-01
* ui-ssdiff: fix decl-after-statement warningsJohn Keeping2016-10-01
* ui-shared: fix decl-after-statement warningsJohn Keeping2016-10-01
* configfile: fix EOF handlingJohn Keeping2016-10-01
* git: update to v2.10.0Christian Hesse2016-09-04
* Fix qry.head leak on errorRichard Maw2016-07-12
* git: update to v2.9.1Christian Hesse2016-07-12
* Link with -ldl on GNU/kFreeBSDPeter Colberg2016-07-06
* Fix spelling in man pagePeter Colberg2016-07-06
* ui-shared: fix segfault when defbranch is NULLEric Wong2016-07-06
* css: consistent use of empty linesChristian Hesse2016-07-05
* ui-log: color line changesChristian Hesse2016-07-05
* Avoid ambiguities when prettifying snapshot namesLukas Fleischer2016-07-05
* git: update to v2.9.0Christian Hesse2016-06-17
* cgit.mk: Use $PKG_CONFIGKylie McClain2016-06-17
* md2html: use utf-8 and flush output bufferJason A. Donenfeld2016-06-17
* Hosted on HTTPS nowJason A. Donenfeld2016-06-07
* Bump version.Jason A. Donenfeld2016-06-07
* git: update to v2.8.3Christian Hesse2016-05-20
* ui-diff: action='.' is not correctJason A. Donenfeld2016-05-12
* forms: action should not be emptyJason A. Donenfeld2016-05-12
* ui-shared: Remove a name attribute with an empty valueJuuso Lapinlampi2016-05-12
* ui-shared: HTML-ize DOCTYPE and <html>Juuso Lapinlampi2016-05-12
* ui-shared: Simplify cgit_print_error_page() logicJuuso Lapinlampi2016-05-12
* git: update to v2.8.2Christian Hesse2016-05-12
* ui-log: Simplify decoration codeTim Nordell2016-05-12
* ui-log: Do not always emit decoration spanTim Nordell2016-05-12
* Renamed repo-specific configuration for enable-html-serving in cgitrc.5.txtMatt Comben2016-03-08
* ui-shared: redirect should not exit early for cacheJason A. Donenfeld2016-02-26
* about: path_info might not be validJason A. Donenfeld2016-02-26
* tabs: do not use target=_blankJason A. Donenfeld2016-02-23
* css: fix indentationJason A. Donenfeld2016-02-23
* css: use less blurry icon for external linkChristian Hesse2016-02-23
* md2html: Do syntax highlighting tooJason A. Donenfeld2016-02-23
* git: update to v2.7.2Christian Hesse2016-02-23
* ui-plain: fix to show a repo's root directory listing in plain viewJoe Anakata2016-02-22
* cmd: redirect empty about/ to homepage or summaryJason A. Donenfeld2016-02-22
* ui-shared: add homepage to tabsJason A. Donenfeld2016-02-22
* ui-atom: avoid DATE_STRFTIMEJohn Keeping2016-02-08
* Avoid DATE_STRFTIME for long/short datesJohn Keeping2016-02-08
* ui-stats: cast pointer before checking for zeroJohn Keeping2016-02-08
[4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse