about summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* | | ui-tag: make output more similar to commit viewLars Hjemli2009-10-06
* | | ui-tag: add snapshot linksAlexey Nezhdanov2009-10-06
* | | Skip leading "/" in url querystring valueStefan Bühler2009-10-06
|/ /
* | Fix repolist search links with virtual rootGeoff Johnstone2009-09-20
* | cgitrc.5.txt: Change repo.group to section in example config.Loui Chang2009-09-14
* | cgitrc.5.txt: Add mansource and manmanual.Loui Chang2009-09-14
|/
* CGIT 0.8.3Lars Hjemli2009-09-13
* Merge branch 'stable'Lars Hjemli2009-09-13
|\
| * CGIT 0.8.2.2Lars Hjemli2009-09-13
* | Merge branch 'lh/repo-scan'Lars Hjemli2009-09-13
|\ \
| * | cgit.c: respect repo-local 'snapshots' option for --scan-pathLars Hjemli2009-08-24
| * | cgit.c: only print first line of repo.desc in print_repo()Lars Hjemli2009-08-24
| * | Add and use cgit_find_stats_periodname() in print_repo()Lars Hjemli2009-08-24
| * | cgit.c: generate repo.snapshots in print_repo()Lars Hjemli2009-08-24
| * | cgit.c: add missing options to print_repo()Lars Hjemli2009-08-24
| * | shared.c: initialize cgit_repo structs properlyLars Hjemli2009-08-24
| * | Add config option 'enable-filter-overrides'Lars Hjemli2009-08-24
| * | cgitrc.5.txt: fix markup errorsLars Hjemli2009-08-24
| * | ui-repolist: handle empty sections similar to NULL sectionsLars Hjemli2009-08-24
| * | Add support for repo-local cgitrc fileLars Hjemli2009-08-24
| * | cgit.c: refactor repo_config() from config_cb()Lars Hjemli2009-08-24
| * | ui-repolist.c: sort by section name, repo name as defaultLars Hjemli2009-08-24
| * | Add config option 'repo.section'Lars Hjemli2009-08-24
| * | Introduce 'section' as canonical spelling for 'repo.group'Lars Hjemli2009-08-24
| * | Add support for --scan-path command line optionLars Hjemli2009-08-24
| * | Rename 'repo.scan' to 'scan-path'Lars Hjemli2009-08-24
| * | cgitrc.5.txt: document repo.scan and cache-scanrc-ttlLars Hjemli2009-08-24
| * | cgit.c: add support for caching autodetected repositoriesLars Hjemli2009-08-24
| * | cgit.c: make print_repolist() and print_repo() reusable for cachingLars Hjemli2009-08-24
| * | cache.h: export hash_str()Lars Hjemli2009-08-24
| * | cgit.c: add support for cgitrc option 'repo.scan'Lars Hjemli2009-08-24
| * | scan-tree: detect non-bare repository and stop scanning earlyLars Hjemli2009-08-24
* | | Merge branch 'fp/linenumbers'Lars Hjemli2009-09-13
|\ \ \
| * | | cgit.css: make the blob display in tree view a bit prettierLars Hjemli2009-08-21
| * | | Rename "linenumbers" to "enable-tree-linenumbers", change default to "1"Lars Hjemli2009-08-21
| * | | Add 'linenumbers' config optionFlorian Pritz2009-08-21
| * | | ui-tree.c: show line numbers when highlightingFlorian Pritz2009-08-21
* | | | Use GIT-1.6.4.3Lars Hjemli2009-09-13
* | | | Merge branch 'stable'Lars Hjemli2009-09-06
|\ \ \ \ | |_|/ / |/| | / | | |/ | |/|
| * | ui-plain.c: only return the blob with the specified pathLars Hjemli2009-09-06
* | | cgitrc.5.txt: fix description and markup for 'snapshots' optionLars Hjemli2009-08-24
| |/ |/|
* | scan-tree: split the pw_gecos field at the ',' to get the real nameStefan Naewe2009-08-20
* | cgit.c: fix caching keyed on PATH_INFO with no QUERY_STRINGLars Hjemli2009-08-20
* | Add and use a common readfile() functionLars Hjemli2009-08-18
* | Merge branch 'stable'Lars Hjemli2009-08-18
|\|
| * truncate buffer before reading empty filesSimon Arlott2009-08-18
* | Merge branch 'stable'Lars Hjemli2009-08-18
|\|
| * ui-shared: don't print header <img/> if there isn't a logo definedMatthew Metnetsky2009-08-18
* | Merge branch 'stable'Lars Hjemli2009-08-17
|\|
| * cgit.c: do not segfault on unexpected query-string formatLars Hjemli2009-08-17
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-20 09:36:05 +0000
how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu