about summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
| * | Generalize doc generationTodd Zullinger2010-09-19
* | | ui-log: Prevent crash when given empty range searchJohan Herland2010-11-10
* | | Makefile: avoid spurious rebuilds of git sources due to `sudo make`Lars Hjemli2010-11-10
* | | ui-log: Fix filecount/linecount when path limit is in effectJohan Herland2010-11-09
* | | Add `strict-export` optionFelix Hanley2010-11-08
* | | Fix a typo in README, s/ExecCGI/+ExecCGIKamil Kaminski2010-11-08
* | | Append path and branch to atom feed titleLars Hjemli2010-11-07
* | | Use committer date for atom feed entry updated elementChris Mayo2010-11-07
* | | Merge branch 'stable'Lars Hjemli2010-11-07
|\ \ \ | | |/ | |/|
| * | Use absolute path for scanned repo readmeDean Scarff2010-11-07
* | | Makefile: add -MP optionLars Hjemli2010-11-07
* | | Merge branch 'stable'Lars Hjemli2010-09-27
|\| |
| * | CGIT 0.8.3.4Lars Hjemli2010-09-27
| * | Use GIT-1.7.3Lars Hjemli2010-09-27
* | | Merge branch 'stable'Lars Hjemli2010-09-19
|\| | | |/ |/|
| * RSS items should always use UTC timesAaron Griffin2010-09-19
* | Merge branch 'ml/bugfix'Lars Hjemli2010-09-19
|\ \
| * | prefer html_raw() to write()Mark Lodato2010-09-04
| * | ui-repolist: fix redefinition of _XOPEN_SOURCEMark Lodato2010-09-04
| * | fix errors in printf-style format stringsMark Lodato2010-09-04
| * | use __attribute__ to catch printf format mistakesMark Lodato2010-09-04
* | | Merge branch 'lh/section-from-path'Lars Hjemli2010-09-19
|\ \ \
| * | | Add support for 'section-from-path' optionLars Hjemli2010-08-22
* | | | Merge branch 'lh/readme'Lars Hjemli2010-09-19
|\ \ \ \
| * | | | Add support for "readme" optionLars Hjemli2010-08-22
| |/ / /
* | / / Use GIT-1.7.3Lars Hjemli2010-09-19
| |/ / |/| |
* | | Merge branch 'stable'Lars Hjemli2010-09-01
|\ \ \ | | |/ | |/|
| * | ui-snapshot: actually compress zip archivesLars Hjemli2010-09-01
* | | Merge branch 'stable'Lars Hjemli2010-08-29
|\| | | |/ |/|
| * html: fix strcpy bug in convert_query_hexcharMark Lodato2010-08-29
| * t0108-patch: add 'tests_done' to endMark Lodato2010-08-29
* | Use GIT-1.7.2.2Lars Hjemli2010-08-22
* | Support refspecs in about-filter.Jason A. Donenfeld2010-08-20
* | Merge branch 'jd/gitolite'Lars Hjemli2010-08-04
|\ \
| * | Add support for 'enable-gitweb-owner' optionJason A. Donenfeld2010-08-04
| * | Add support for 'remove-suffix' optionJason A. Donenfeld2010-08-04
| * | Add support for 'project-list' optionJason A. Donenfeld2010-08-04
* | | Merge branch 'js/notes'Lars Hjemli2010-08-04
|\ \ \
| * | | ui-log: Display git notes when presentJeff Smith2010-08-04
| * | | ui-commit: Display git notes when presentJeff Smith2010-08-04
| |/ /
* | | Merge branch 'stable'Lars Hjemli2010-08-03
|\ \ \ | |/ / |/| / | |/
| * CGIT 0.8.3.3Lars Hjemli2010-08-03
| * ui-refs.c: avoid segfault on unparsed ref objectsLars Hjemli2010-08-03
* | commit-links.sh: Seperate the expressions for filtering commit messages.Jeff Smith2010-07-22
* | Makefile: do not include dependency-file on `make clean`Lynn Lin2010-07-22
* | Merge branch 'jh/ignorews'Lars Hjemli2010-07-18
|\ \
| * | ui-diff: Add link to ignore/show whitespace changes in diffsJohan Herland2010-07-18
| * | Add URL parameter 'ignorews' for optionally ignoring whitespace in diffsJohan Herland2010-07-18
* | | Merge branch 'lh/macros'Lars Hjemli2010-07-18
|\ \ \
| * | | Add support for environment variable expansionLars Hjemli2010-03-22
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-18 10:51:23 +0000
t in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu