about summary refs log tree commit diff
Commit message (Expand)AuthorAge
...
* ui-repolist: use ctx.qry.url instead of rooturl, in case we're filteringJason A. Donenfeld2015-03-03
* ui-repolist: use correct owner query linkJason A. Donenfeld2015-03-03
* Simplify commit and tag parsingLukas Fleischer2015-03-03
* git: update to v2.3.1Christian Hesse2015-03-03
* Bump verisonJason A. Donenfeld2015-02-15
* shrink cgit.png file sizeChristian Hesse2015-02-15
* ui-clone.c: Fix off-by-one error in pack pathJason A. Donenfeld2015-02-09
* ui-clone.c: Fix path checkLukas Fleischer2015-02-09
* git: update for v2.3.0Christian Hesse2015-02-08
* ui-shared.c: Refactor add_clone_urls()Lukas Fleischer2015-02-05
* Add repo.hide and repo.ignoreLukas Fleischer2015-01-29
* Add Etags for snapshotsJanus2015-01-28
* tag: reference with "h" instead of "id"John Keeping2015-01-19
* Return proper HTTP response when accessing info/Lukas Fleischer2015-01-15
* git: update to v2.2.2Christian Hesse2015-01-13
* ui-diff: don't link to single file diff statJohn Keeping2014-12-30
* ui-patch: match git-format-patch(1) outputJohn Keeping2014-12-28
* t0108: modernize styleJohn Keeping2014-12-28
* Revert "git: use xz compressed archive for download"Jason A. Donenfeld2014-12-24
* Use split_ident_line() in parse_user()Lukas Fleischer2014-12-24
* footer: link back to cgit home pageJason A. Donenfeld2014-12-23
* ui-shared: show absolute time in tooltip for relative datesJohn Keeping2014-12-23
* git: use xz compressed archive for downloadChristian Hesse2014-12-23
* match other common markdown file extensionsChris Burroughs2014-12-23
* repolist: add owner-filterChris Burroughs2014-12-23
* ui-shared: add rel-vcs microformat links to HTML headerJohn Keeping2014-12-23
* ui-summary: add "rel='vcs-git'" to clone URL linksJohn Keeping2014-12-23
* Extract clone URL printing to ui-shared.cJohn Keeping2014-12-23
* Remove trailing slash after remove-suffixLukas Fleischer2014-12-23
* git: update to v2.2.1Christian Hesse2014-12-23
* filter: fix libravatar email-filter https issueChristian Hesse2014-12-13
* ui-diff: add "stat only" diff typeJohn Keeping2014-12-13
* Change "ss" diff flag to an enumJohn Keeping2014-12-13
* ui-shared: remove toggle_ssdiff arg to cgit_diff_link()John Keeping2014-12-13
* ui-shared: remove toggle_ssdiff arg to cgit_commit_link()John Keeping2014-12-13
* git: update to v2.0.4John Keeping2014-08-07
* Always check if README exists in choose_readme()Lukas Fleischer2014-08-07
* cgitrc.5: we mean a cgi response, not requestJason A. Donenfeld2014-08-01
* ui-stats.c: set parent pointer to NULL after freeing itJohn Keeping2014-07-28
* git: update to v2.0.3John Keeping2014-07-28
* parsing.c: make commit buffer constJohn Keeping2014-07-28
* Bump version.Jason A. Donenfeld2014-06-30
* remove debug fprinf() calls that sneaked in with commit 79c985Christian Hesse2014-06-29
* git: update to 2.0.1Christian Hesse2014-06-28
* ui-patch: Flush stdout after outputting dataJohn Keeping2014-06-28
* ui-log: ignore unhandled argumentsJohn Keeping2014-06-28
* git: update for git 2.0Christian Hesse2014-06-28
* remove trailing whitespaces from source filesChristian Hesse2014-04-17
* git: update to 1.9.2Christian Hesse2014-04-12
* Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice2014-04-05
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-10-07 20:31:25 +0000
he nearest 1024-byte boundary in the patch body. E.g.: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767] Patch is complete, without truncation. Next hit, with cache in place: > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4 > fdad5157bb9e88777d525704aba24389bee" ... > 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096] Length truncated to 4096. The cache on disk looks truncated as well, so the bug must me during the process of saving cache. The same is true for larger patches: > mricon@nikko:[/tmp]$ wget -O no-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644] 979644 bytes with a cache-miss > mricon@nikko:[/tmp]$ wget -O yes-cache > "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c > 566e95599cd60c7143762ca8b49d9395050" ... > 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944] 978944 (956KB exactly) with a cache-hit Since the "html" functions use raw write(2) to STDIO_FILENO, we don't notice problems with most pages, but raw patches write using printf(3). This is fine if we're outputting straight to stdout since the buffers are flushed on exit, but we close the cache output before this, so the cached output ends up being truncated. Make sure the buffers are flushed when we finish outputting a patch so that we avoid this. No other UIs use printf(3) so we do not need to worry about them. Actually, it's slightly more interesting than this... since we don't set GIT_FLUSH, Git decides whether or not it will flush stdout after writing each commit based on whether or not stdout points to a regular file (in maybe_flush_or_die()). Which means that when writing directly to the webserver, Git flushes stdout for us, but when we redirect stdout to the cache it points to a regular file so Git no longer flushes the output for us. The patch is still correct, but perhaps the full explanation is interesting! Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28ui-log: ignore unhandled argumentsJohn Keeping If you search for a bogus range string here: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ Using something like "range" and "qwerty123456", it returns an "Internal Server Error" and the following in the logs: > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal: > ambiguous argument 'qwerty123456': unknown revision or path not in the > working tree., referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to > separate paths from revisions, like this:, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command> > [<revision>...] -- [<file>...]', referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ > [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end > of script headers: cgit, referer: > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/ The cache will kick in, so if you search for the same string again, it'll show an empty range, so you have to change the bogus strings each time. This is because we just pass the arguments straight to Git's revision parsing machinery which die()s if it cannot parse an argument, printing the above to stderr and exiting. The patch below makes it a bit friendlier by just ignoring unhandled arguments, but I can't see an easy way to report errors when we can't parse revision arguments without losing the flexibility of supporting all of the revision specifiers supported by Git. Reported-by: Konstantin Ryabitsev <mricon@kernel.org> 2014-06-28git: update for git 2.0Christian Hesse prefixcmp() and suffixcmp() have been remove, functionality is now provided by starts_with() and ends_with(). Retrurn values have been changed, so instead of just renaming we have to fix logic. Everything else looks just fine. 2014-04-17remove trailing whitespaces from source filesChristian Hesse 2014-04-12git: update to 1.9.2Christian Hesse Everything works just bumping the version in Makefile and commit hash in submodule. No code changes required. 2014-04-05Fix cgit_parse_url when a repo url is contained in another repo urlJulian Maurice For example, if I have two repos (remove-suffix is enabled): /foo /foo/bar http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'" instead of "repository 'foo/bar'" 2014-03-20Makefile: use more reliable git tarball mirrorJason A. Donenfeld 2014-03-20git: update to 1.9.1Christian Hesse