about summary refs log tree commit diff
path: root/Makefile (unfollow)
Commit message (Expand)Author
2008-09-03Update Makefile to use GIT-1.6.0.1Lars Hjemli
2008-09-02Use GIT-1.6.0.1Lars Hjemli
2008-09-02ui-plain: handle subdirectoriesLars Hjemli
2008-09-01Use GIT-1.6.0Lars Hjemli
2008-09-01cache.c: use %zd for off_t argumentLars Hjemli
2008-08-06Supply status description to html_status()Lars Hjemli
2008-08-06Use GIT-1.6.0.rc1Lars Hjemli
2008-08-06Makefile: Git dependency, take 3Lars Hjemli
2008-08-06ui-tree: link to plain view instead of blob viewLars Hjemli
2008-08-06Implement plain viewLars Hjemli
2008-08-06Add support for cloning over httpLars Hjemli
2008-08-05cgitrc: explain new local-time optionStefan Naewe
2008-08-01Add atom-supportLars Hjemli
2008-08-01Added `local-time` option to cgitrcStefan Naewe
2008-08-01Makefile: another take on git dependency rulesLars Hjemli
2008-07-27Modify default value for a few cgitrc optionsLars Hjemli
2008-07-27Be prepared for empty repositoriesLars Hjemli
2008-07-27ui-shared: show repo owner along with descriptionLars Hjemli
2008-07-27ui-summary: show clone urlsLars Hjemli
2008-07-22Makefile: remove the `distclean` and `emptycache` targetsLars Hjemli
2008-07-22Makefile: do not touch the git objects with `make clean`Lars Hjemli
2008-07-22Makefile: fix git dependency rulesLars Hjemli
2008-07-22tests/Makefile: not everyone has `.` in $PATHLars Hjemli
2008-07-21Adjust to new calling convention for read_tree_recursive()Lars Hjemli
2008-07-21Use GIT-1.6.0-rc0Lars Hjemli
2008-07-19Add a favicon option to cgitrcLars Hjemli
2008-06-26Add support for including a footer on all pagesLars Hjemli
2008-06-25Use GIT-1.5.6Lars Hjemli
2008-06-24allow specification of directly linked blobs mimetypesMichael Krelin
2008-06-24allow blob extract blobs by head/path combinationMichael Krelin
2008-05-21Added root-desc to default configuration.Harley Laue
2008-05-20ui-tree.c: avoid peeking at GITLINK objectsLars Hjemli
2008-05-20cache.c: fix error checking in print_slot()Lars Hjemli
2008-05-18cache.c: do not ignore errors from print_slot()Lars Hjemli
2008-05-18cache.c: use xread()/xwrite() from libgitLars Hjemli
2008-05-18cache.c: make all io-related functions return errno on errorLars Hjemli
2008-05-18cache.c: read(2) returns -1 on error, not 0Lars Hjemli
2008-05-18Use GIT-1.5.5.1Lars Hjemli
2008-05-18Include commit-id in link from diff-statLars Hjemli
2008-05-18ui-commit: handle root commitsLars Hjemli
2008-05-04Add link to index page from repo header, remove page nameLars Hjemli
2008-05-03Add footer with page creation time and cgit version on all pagesLars Hjemli
2008-05-03Add a pager on the repolistLars Hjemli
2008-05-03Add cgit_index_link() function with support for offsetLars Hjemli
2008-04-29Print an error if filename is not found in html_include.Harley Laue
2008-04-29Add 'about site' and 'about repo' pagesLars Hjemli
2008-04-29Prepare for 'about site' page / add 'root-readme' option to cgitrcLars Hjemli
2008-04-29Make it possible for a single cmd to work both with and without a repoLars Hjemli
2008-04-29Re-enable 'index-info' and add support for 'root-desc' in cgitrcLars Hjemli
2008-04-29Move included header-file out of repolist tableLars Hjemli
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-02-21 17:05:53 +0000
2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu