about summary refs log tree commit diff
path: root/Makefile (follow)
Commit message (Expand)AuthorAge
* Use GIT-1.6.3.4Lars Hjemli2009-08-16
* Merge branch 'stable'Lars Hjemli2009-03-15
|\
| * CGIT 0.8.2.1Lars Hjemli2009-03-15
* | Fix doc-related glitches in Makefile and .gitignoreLars Hjemli2009-03-15
* | Makefile: add doc-related targetsLars Hjemli2009-02-12
|/
* CGIT 0.8.2Lars Hjemli2009-02-01
* Use GIT-1.6.1.1Lars Hjemli2009-02-01
* Merge branch 'stable'Lars Hjemli2009-01-27
|\
| * CGIT 0.8.1.1Lars Hjemli2009-01-27
* | Merge branch 'lh/stats'Lars Hjemli2009-01-27
|\ \
| * | Add a 'stats' page to each repoLars Hjemli2008-12-06
* | | Merge branch 'stable'Lars Hjemli2009-01-12
|\ \ \ | | |/ | |/|
| * | Makefile: install cgit.{css,png} in CGIT_DATA_PATHTodd Zullinger2009-01-12
| * | Makefile: add INSTALL var to set install commandTodd Zullinger2009-01-12
* | | Merge branch 'stable'Lars Hjemli2009-01-11
|\| |
| * | Makefile: avoid libcurl when building gitLars Hjemli2009-01-10
* | | Use GIT-1.6.1Lars Hjemli2008-12-26
|/ /
* | Makefile: allow cgit.conf to override platform-specific tweaksLars Hjemli2008-12-05
* | Extra cygwin-specific changesRamsay Jones2008-12-03
* | Use mode 0644 for non-executable filesKarl Chen2008-11-06
* | Use GIT-1.6.0.3Lars Hjemli2008-11-06
|/
* CGIT 0.8.1Lars Hjemli2008-10-11
* Makefile: enable compilation on uclibcLars Hjemli2008-10-11
* CGIT 0.8Lars Hjemli2008-10-05
* Use GIT-1.6.0.2Lars Hjemli2008-10-05
* Add LDFLAGS to makefile.Harley Laue2008-09-20
* Add support for --scan-tree=<path> option to cgitLars Hjemli2008-09-15
* Update Makefile to use GIT-1.6.0.1Lars Hjemli2008-09-03
* Merge branch 'lh/plain'Lars Hjemli2008-09-01
|\
| * Implement plain viewLars Hjemli2008-08-06
* | Merge branch 'lh/clone'Lars Hjemli2008-09-01
|\|
| * Add support for cloning over httpLars Hjemli2008-08-06
* | Use GIT-1.6.0.rc1Lars Hjemli2008-08-06
* | Makefile: Git dependency, take 3Lars Hjemli2008-08-06
* | Add atom-supportLars Hjemli2008-08-01
|/
* Makefile: another take on git dependency rulesLars Hjemli2008-08-01
* Makefile: remove the `distclean` and `emptycache` targetsLars Hjemli2008-07-22
* Makefile: do not touch the git objects with `make clean`Lars Hjemli2008-07-22
* Makefile: fix git dependency rulesLars Hjemli2008-07-22
* Use GIT-1.5.6Lars Hjemli2008-06-25
* Use GIT-1.5.5.1Lars Hjemli2008-05-18
* Use GIT-1.5.5Lars Hjemli2008-04-09
* Merge branch 'lh/cleanup'Lars Hjemli2008-04-08
|\
| * Move function for configfile parsing into configfile.[ch]Lars Hjemli2008-03-28
| * Makefile: copy the QUIET constructs from the Makefile in git.gitLars Hjemli2008-03-25
| * Move cgit_version from shared.c to cgit.cLars Hjemli2008-03-24
| * Makefile: autobuild dependency rulesLars Hjemli2008-03-24
| * Initial Makefile cleanupLars Hjemli2008-03-24
| * Add command dispatcherLars Hjemli2008-03-24
* | Use GIT-1.5.5.rc1Lars Hjemli2008-03-23
generated by cgit-pink 1.4.1 (git 2.36.1) at 2026-10-26 19:18:01 +0000
was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu