about summary refs log tree commit diff
path: root/cgit.c (unfollow)
Commit message (Expand)Author
2016-11-23Bump version.Jason A. Donenfeld
2016-11-23css: highlight even table rows and skip empty rowsChristian Hesse
2016-11-06git: update to v2.10.2Christian Hesse
2016-10-12ui-blog: fix oid handlingChristian Hesse
2016-10-12shared: remove unused function strlpart()Christian Hesse
2016-10-12shared: remove unused function strrpart()Christian Hesse
2016-10-12ui-repolist: fix memory leakChristian Hesse
2016-10-12Use skip_prefix() to get rid of magic constantsLukas Fleischer
2016-10-12patch: reapply path limitJohn Keeping
2016-10-07ui-repolist: fix memory leakChristian Hesse
2016-10-04git: update to v2.10.1Christian Hesse
2016-10-04ui-tree: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-tag: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-snapshot: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-shared: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-plain: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-patch: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-log: replace get_sha1() with get_oid()Christian Hesse
2016-10-04ui-commit: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04ui-blob: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-04cgit: replace 'unsigned char sha1[20]' with 'struct object_id oid'Christian Hesse
2016-10-01Makefile: remove extra spaceJason A. Donenfeld
2016-10-01Simplify http_parse_querystring()Lukas Fleischer
2016-10-01ui-tree: remove a fixed size bufferJohn Keeping
2016-10-01ui-tag: clean up taginfoJohn Keeping
2016-10-01shared: make cgit_free_taginfo() publicJohn Keeping
2016-10-01shared: remove return value from cgit_free_commitinfo()John Keeping
2016-10-01tree: allow skipping through single-child treesJohn Keeping
2016-10-01ui-ssdiff: fix decl-after-statement warningsJohn Keeping
2016-10-01ui-shared: fix decl-after-statement warningsJohn Keeping
2016-10-01configfile: fix EOF handlingJohn Keeping
2016-09-04git: update to v2.10.0Christian Hesse
2016-07-12Fix qry.head leak on errorRichard Maw
2016-07-12git: update to v2.9.1Christian Hesse
2016-07-06Link with -ldl on GNU/kFreeBSDPeter Colberg
2016-07-06Fix spelling in man pagePeter Colberg
2016-07-06ui-shared: fix segfault when defbranch is NULLEric Wong
2016-07-05css: consistent use of empty linesChristian Hesse
2016-07-05ui-log: color line changesChristian Hesse
2016-07-05Avoid ambiguities when prettifying snapshot namesLukas Fleischer
2016-06-17git: update to v2.9.0Christian Hesse
2016-06-17cgit.mk: Use $PKG_CONFIGKylie McClain
2016-06-17md2html: use utf-8 and flush output bufferJason A. Donenfeld
2016-06-07Hosted on HTTPS nowJason A. Donenfeld
2016-06-07Bump version.Jason A. Donenfeld
2016-05-20git: update to v2.8.3Christian Hesse
2016-05-12ui-diff: action='.' is not correctJason A. Donenfeld
2016-05-12forms: action should not be emptyJason A. Donenfeld
2016-05-12ui-shared: Remove a name attribute with an empty valueJuuso Lapinlampi
2016-05-12ui-shared: HTML-ize DOCTYPE and <html>Juuso Lapinlampi
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-02-17 04:09:52 +0000
ng into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu