about summary refs log tree commit diff
path: root/cgit.h (unfollow)
Commit message (Expand)Author
2009-11-28"max-blob-size" config var to limit generated HTML sizeGeorg Lukas
2009-11-28cgit.css: highlight directories in treeGeorg Lukas
2009-11-19syntax highlighting for all formats supported by "highlight"Georg Lukas
2009-11-07Add support for remote branchesLars Hjemli
2009-11-07shared.c: return original errnoLars Hjemli
2009-11-07Add NO_OPENSSL optionMikhail Gusarov
2009-11-07In side-by-side diff, add support for marking individual characters.Ragnar Ouchterlony
2009-11-07Close fd on error in readfile()Rys Sommefeldt
2009-11-07Nov is the correct abbreviationDanijel Tašov
2009-10-16ui-shared.c: prettify download links when generated from tag pageLars Hjemli
2009-10-06ui-tag: make output more similar to commit viewLars Hjemli
2009-10-06ui-tag: add snapshot linksAlexey Nezhdanov
2009-10-06Skip leading "/" in url querystring valueStefan Bühler
2009-09-20Fix repolist search links with virtual rootGeoff Johnstone
2009-09-16Fixed side-by-side diff bugs related to binary diff and more.Ragnar Ouchterlony
2009-09-16Polishing of how the side-by-side diff looks.Ragnar Ouchterlony
2009-09-16Add possibility to switch between unidiff and side-by-side-diff.Ragnar Ouchterlony
2009-09-16First version of side-by-side diff.Ragnar Ouchterlony
2009-09-14cgitrc.5.txt: Change repo.group to section in example config.Loui Chang
2009-09-14cgitrc.5.txt: Add mansource and manmanual.Loui Chang
2009-09-13CGIT 0.8.3Lars Hjemli
2009-09-13CGIT 0.8.2.2Lars Hjemli
2009-09-13Use GIT-1.6.4.3Lars Hjemli
2009-09-06ui-plain.c: only return the blob with the specified pathLars Hjemli
2009-08-24cgit.c: respect repo-local 'snapshots' option for --scan-pathLars Hjemli
2009-08-24cgit.c: only print first line of repo.desc in print_repo()Lars Hjemli
2009-08-24Add and use cgit_find_stats_periodname() in print_repo()Lars Hjemli
2009-08-24cgit.c: generate repo.snapshots in print_repo()Lars Hjemli
2009-08-24cgit.c: add missing options to print_repo()Lars Hjemli
2009-08-24shared.c: initialize cgit_repo structs properlyLars Hjemli
2009-08-24Add config option 'enable-filter-overrides'Lars Hjemli
2009-08-24cgitrc.5.txt: fix markup errorsLars Hjemli
2009-08-24ui-repolist: handle empty sections similar to NULL sectionsLars Hjemli
2009-08-24Add support for repo-local cgitrc fileLars Hjemli
2009-08-24cgit.c: refactor repo_config() from config_cb()Lars Hjemli
2009-08-24ui-repolist.c: sort by section name, repo name as defaultLars Hjemli
2009-08-24Add config option 'repo.section'Lars Hjemli
2009-08-24Introduce 'section' as canonical spelling for 'repo.group'Lars Hjemli
2009-08-24Add support for --scan-path command line optionLars Hjemli
2009-08-24Rename 'repo.scan' to 'scan-path'Lars Hjemli
2009-08-24cgitrc.5.txt: document repo.scan and cache-scanrc-ttlLars Hjemli
2009-08-24cgit.c: add support for caching autodetected repositoriesLars Hjemli
2009-08-24cgit.c: make print_repolist() and print_repo() reusable for cachingLars Hjemli
2009-08-24cache.h: export hash_str()Lars Hjemli
2009-08-24cgit.c: add support for cgitrc option 'repo.scan'Lars Hjemli
2009-08-24scan-tree: detect non-bare repository and stop scanning earlyLars Hjemli
2009-08-24cgitrc.5.txt: fix description and markup for 'snapshots' optionLars Hjemli
2009-08-21cgit.css: make the blob display in tree view a bit prettierLars Hjemli
2009-08-21Rename "linenumbers" to "enable-tree-linenumbers", change default to "1"Lars Hjemli
2009-08-21Add 'linenumbers' config optionFlorian Pritz
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-10-05 00:30:45 +0000
tf.c?id=325a460c7942aa79bb97303e129980db8afd177c&follow=1'>builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu