about summary refs log tree commit diff
path: root/html.c (follow)
Commit message (Expand)AuthorAge
* Fix fmt() off-by-one errorlemon2022-02-18
* Use buffered stdioEric Wong2022-02-13
* html: html_ntxt with no ellipsisJeff Smith2017-10-03
* Simplify http_parse_querystring()Lukas Fleischer2016-10-01
* ui-shared: prevent malicious filename from injecting headersJason A. Donenfeld2016-01-14
* html: remove html_status()John Keeping2015-08-14
* Remove redundant includesJohn Keeping2015-08-13
* html: avoid using a plain integer as a NULL pointerJohn Keeping2015-03-09
* html: remove redundant htmlfd variableJohn Keeping2014-01-12
* Update copyright informationLukas Fleischer2014-01-08
* html.c: die when write failsJohn Keeping2013-05-22
* html.c: add various strbuf and varadic helpersJohn Keeping2013-04-08
* html.c: Replace strdup() with xstrdup()Lukas Fleischer2013-04-08
* Always #include corresponding .h in .c filesJohn Keeping2013-04-08
* html: check return value of writeJason A. Donenfeld2013-03-20
* Mark several functions/variables staticLukas Fleischer2013-03-04
* White space around control verbs.Jason A. Donenfeld2013-03-04
* Fix several whitespace errorsLukas Fleischer2013-03-04
* Merge branch 'stable'Lars Hjemli2011-07-21
|\
| * html.c: avoid out-of-bounds access for url_escape_tableEric Wong2011-07-21
* | Merge branch 'stable'Lars Hjemli2011-05-30
|\|
| * Properly escape ampersands inside HTML attributesLukas Fleischer2011-05-30
* | Merge branch 'lh/panel'Lars Hjemli2011-05-23
|\ \ | |/ |/|
| * html.c: add html_intoption()Lars Hjemli2011-03-06
* | Fix memory leak in http_parse_querystring().Lukas Fleischer2011-05-23
* | Fix escaping of paths with spacesJonathon Mah2011-05-23
|/
* Merge branch 'stable'Lars Hjemli2011-03-05
|\
| * do not infloop on a query ending in %XY, for invalid hex X or YJim Meyering2011-03-05
* | html.c: use '+' to escape spaces in urlsLars Hjemli2010-11-10
* | prefer html_raw() to write()Mark Lodato2010-09-04
* | Merge branch 'stable'Lars Hjemli2010-08-29
|\|
| * html: fix strcpy bug in convert_query_hexcharMark Lodato2010-08-29
* | html: properly percent-escape URLsMark Lodato2010-02-09
* | html: make all strings 'const char *'Mark Lodato2010-02-08
|/
* html.c: use correct escaping in html attributesLars Hjemli2009-01-29
* html.c: add html_url_pathLars Hjemli2008-10-05
* html.c: add html_url_argLars Hjemli2008-10-05
* Supply status description to html_status()Lars Hjemli2008-08-06
* Implement plain viewLars Hjemli2008-08-06
* Add support for cloning over httpLars Hjemli2008-08-06
* Print an error if filename is not found in html_include.Harley Laue2008-04-29
* Merge branch 'lh/cleanup'Lars Hjemli2008-04-08
|\
| * Move cgit_parse_query() from parsing.c to html.c as http_parse_querystring()Lars Hjemli2008-04-08
| * Introduce html.hLars Hjemli2008-03-18
* | Merge branch 'stable'Lars Hjemli2008-02-23
|\ \ | |/ |/|
| * Fix segfaultHiroki Hattori2008-02-23
* | Fix html error detected by test-suiteLars Hjemli2007-11-11
|/
* Add html_option() functionLars Hjemli2007-10-28
* Rename dirlink to gitlink.Jeffrey C. Ollie2007-06-04
* Add html_include()Lars Hjemli2007-05-18
generated by cgit-pink 1.4.1 (git 2.36.1) at 2025-02-19 22:01:05 +0000
rbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu