about summary refs log tree commit diff
path: root/ui-plain.c (follow)
Commit message (Expand)AuthorAge
* Switch to exclusively using global ctxLukas Fleischer2014-01-17
* Update copyright informationLukas Fleischer2014-01-08
* plain: don't append charset for binary MIME typesJohn Keeping2014-01-08
* use struct strbuf instead of static buffersJohn Keeping2013-04-08
* Remove redundant calls to fmt("%s", ...)John Keeping2013-04-08
* Mark char* fields in struct cgit_page as constJohn Keeping2013-04-08
* Always #include corresponding .h in .c filesJohn Keeping2013-04-08
* ui-plain.c: Use a context structure in walk_tree()Lukas Fleischer2013-03-04
* ui-plain.c: Do not access match variable in print_*()Lukas Fleischer2013-03-04
* Update git to v1.7.6.5John Keeping2013-03-02
* Merge branch 'fh/mimetypes'Lars Hjemli2012-03-18
|\
| * ui_plain: automatically lookup mimetype when mimetype-file is setFerry Huberts2011-07-19
* | ui-plain.c: add support for path-selected submodule linksLars Hjemli2011-06-15
|/
* ui-plain.c: fix html and links generated by print_dir() and print_dir_entry()Lars Hjemli2011-06-12
* Use GIT-1.7.2.2Lars Hjemli2010-08-22
* ui-plain: print directory listingsMark Lodato2010-01-31
* ui-plain: more efficient walk_tree()Mark Lodato2010-01-31
* ui-plain: remove unused curr_rev variableMark Lodato2010-01-30
* Fix segfault on ppc when browsing treeMartins Polakovs2009-12-12
* Merge branch 'stable'Lars Hjemli2009-09-06
|\
| * ui-plain.c: only return the blob with the specified pathLars Hjemli2009-09-06
* | Add support for mime type registration and lookupLars Hjemli2009-07-25
* | Merge branch 'plain-etag'Lars Hjemli2009-07-25
|\ \
| * | Add support for ETag in 'plain' viewLars Hjemli2009-02-19
| |/
* / ui-plain: Return 'application/octet-stream' for binary files.Remko Tronçon2009-07-25
|/
* Fix some warnings to allow -WerrorRamsay Jones2008-11-06
* ui-plain: handle subdirectoriesLars Hjemli2008-09-02
* Supply status description to html_status()Lars Hjemli2008-08-06
* Implement plain viewLars Hjemli2008-08-06
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-23 03:39:55 +0000
an='3' class='logmsg'> Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu